From: Andi Kleen <andi@firstfloor.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: nanditad@google.com, netdev@vger.kernel.org,
codel@lists.bufferbloat.net, mattmathis@google.com,
ncardwell@google.com, David Miller <davem@davemloft.net>
Subject: Re: [Codel] [PATCH v3 net-next] tcp: TCP Small Queues
Date: Wed, 11 Jul 2012 11:38:31 -0700 [thread overview]
Message-ID: <m2r4sirvmg.fsf@firstfloor.org> (raw)
In-Reply-To: <1342021831.3265.8174.camel@edumazet-glaptop> (Eric Dumazet's message of "Wed, 11 Jul 2012 17:50:31 +0200")
Eric Dumazet <eric.dumazet@gmail.com> writes:
> +
> + if (!sock_owned_by_user(sk)) {
> + if ((1 << sk->sk_state) &
> + (TCPF_ESTABLISHED | TCPF_FIN_WAIT1 |
> + TCPF_CLOSING | TCPF_CLOSE_WAIT))
> + tcp_write_xmit(sk,
> + tcp_current_mss(sk),
> + 0, 0,
> + GFP_ATOMIC);
Did you have any problems with the GFP_ATOMIC allocation failing here?
I think you move some skb allocs from process context to ATOMIC, right?
It relies on the VM somehow catching up in another context.
May be interesting to try out under very high memory pressure.
-Andi
--
ak@linux.intel.com -- Speaking for myself only
next prev parent reply other threads:[~2012-07-11 18:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 15:50 Eric Dumazet
2012-07-11 18:38 ` Andi Kleen [this message]
2012-07-11 23:47 ` Eric Dumazet
2012-07-11 19:29 ` Nandita Dukkipati
2012-07-12 0:00 ` Eric Dumazet
2012-07-12 0:46 ` Nandita Dukkipati
2012-07-12 1:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/codel.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2r4sirvmg.fsf@firstfloor.org \
--to=andi@firstfloor.org \
--cc=codel@lists.bufferbloat.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=mattmathis@google.com \
--cc=nanditad@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox