From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 549F73B2A4 for ; Mon, 18 Mar 2019 05:26:24 -0400 (EDT) Received: by mail-qk1-x731.google.com with SMTP id g1so4940826qki.5 for ; Mon, 18 Mar 2019 02:26:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Ebo5BBT5b+T40wg5y3vSNq4CC1JmzyzEYNr5kVR/Mgk=; b=ZkeTjEezdNyI8zTL9cdl0pDGlnFHMSvvWzSip3AFxWnvdLAPlRMJWocLcLjrA6nixC iFn1zeDJoZLxR03EMJkOIlm8/9afTIALFhH2MB1EGt/8kZjaAkpVd/LgQmChMg+GVFVW s6qDna/8Y7Ur+hsLItOyOU2k9qB2m6f+TbkKJCsXQEHRC8PMYX0DN5w74zlcbs6h+jTe f+bQH8Pq1ccPNs2Y89/Y6cN/jfUagdTkW5uuKEJN6IDQXsjjELbx6BKzbcguquwnnICj +RXDn5DzNnipbzoHXAwsyFfgGF+rQTl0tJ6iqo2tFJ0WVrR37BxmiTirNg13HsOqFcHS auaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Ebo5BBT5b+T40wg5y3vSNq4CC1JmzyzEYNr5kVR/Mgk=; b=VMWfABqy13r2rWbXY15uGpEtQEfv+9E/FD1EBmSuXGU7S8pRiFEGlMBCM1D9M/Yhkd 8lbJObcKCCD0l6JDAzhUnW/NHc5hZkpbQJTheOQyaRneaSJD70w6Tcp/+raezo3+naVU j3Hch99THl8TtHjRCpGDcL3JgnADHZQS669ComI1ago32iadb0rYBiR/rmWi/aMrDN6Y 5LKrMQA6L1rCtSXklVG6Ywn4ATuW2gYlGgVljtSrgQgBU8E3dpag1kwuZMq8Ol2HhIpe P9QGhL+Jr/w96K6tBVO+b903J4XEya5Fygwjt+ITZo9Tp0JsBLYbrQ4AytzB9P9yq6Tb Rs1Q== X-Gm-Message-State: APjAAAUA/JeQZ1s4uVe9uaf2dJKjPjFnYcKaxyiCudh+3OiOtdPiJipV zsCH+RiAPR4QPMKfPT8OMR9CT+ySRfj+yUifLk0= X-Google-Smtp-Source: APXvYqwXQLldrxqbsywL1liRUqtgUNaqFz4P4H6HC696emFj17ITn0J7K/quwbR+elO7qjZI0YlA7Zx+2sMBoEBZ6zM= X-Received: by 2002:a05:620a:1486:: with SMTP id w6mr10601855qkj.179.1552901183826; Mon, 18 Mar 2019 02:26:23 -0700 (PDT) MIME-Version: 1.0 References: <189cdc56-9eff-4a9f-aee1-1eea06d78664@googlegroups.com> <0d5b5f96-ec5d-4055-9cdc-7b650dbb7ea5@googlegroups.com> <567ee54b-3cad-4e65-9803-d4a7f0553adc@googlegroups.com> In-Reply-To: <567ee54b-3cad-4e65-9803-d4a7f0553adc@googlegroups.com> From: Dave Taht Date: Mon, 18 Mar 2019 02:26:12 -0700 Message-ID: To: Jared Newman Cc: BBR Development , ecn-sane@lists.bufferbloat.net Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Ecn-sane] [bbr-dev] Applying BBRv2 patches X-BeenThere: ecn-sane@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussion of explicit congestion notification's impact on the Internet List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Mar 2019 09:26:24 -0000 On Thu, Mar 14, 2019 at 11:21 AM Jared Newman wrote= : > > Hey Neal, > > Just a quick update: turns out the 1-2 second delays we were seeing were = because we had a net.ipv4.tcp_notsent_lowat of 4MB (!!). Setting this to 16= KB made BBR perform beautifully on the link, and reduced all queue delays t= o within the expected RTT variance. I'm still keen on comparing BBR with an= d without these patches, so will report back shortly with these results. I am a huge fan of this option, (apple has it too) and certainly the default is far too high. I would really love to have an equivalent net.ipv4.tcp_notsent_lowat for udp sockets as well as a setsockopt. Has that happened yet? > Cheers, > Jared. > > On Tuesday, March 12, 2019 at 10:50:40 PM UTC-7, Neal Cardwell wrote: >> >> Thanks for the report! We'd be interested to hear how it goes. >> >> thanks, >> neal >> >> On Tue, Mar 12, 2019 at 10:44 PM Jared Newman wrote= : >>> >>> Ah awesome, glad to see the improvements make it into the next kernel! = Thanks for the pointers and quick response, Neal. >>> >>> We're running TCP BBR on a 2.4GHz mobile ad hoc network and are seeing = an excessive outgoing queue build up, leading to application delays of 1-2 = seconds on a link that has a BBR-estimated min-RTT of ~15ms. By the sounds = of it, feature (2) will be what we want so we'll try applying the patches o= n top of 18845557fd6f and see how things go. >>> >>> Cheers, >>> Jared. >>> >>> On Tuesday, March 12, 2019 at 10:29:08 PM UTC-7, Neal Cardwell wrote: >>>> >>>> Hi, >>>> >>>> For the patches in https://groups.google.com/forum/#!topic/bbr-dev/8p= gyOyUavvY there were two main features: >>>> >>>> (1) Higher throughput for wifi and other paths with aggregation >>>> >>>> (2) Lower queuing delays by frequently draining excess in-flight data >>>> >>>> >>>> For the patches related to (1), that functionality is already in davem= /net-next and torvalds/linux, as of recently, and those patches will be in = Linux 5.1. We were waiting until Linux 5.1 is released to announce that on = this e-mail list. But since it came up anyway, we may as well mention it. ;= -) >>>> >>>> >>>> For the patches related to (2), that functionality is still undergoing= testing on YouTube and elsewhere. >>>> >>>> >>>> If you want to apply the original patches from https://groups.google.= com/forum/#!topic/bbr-dev/8pgyOyUavvY then you can apply them on top of th= e Linux commit: >>>> >>>> 18845557fd6f >>>> >>>> from March 2018. That's where they were originally generated. >>>> >>>> >>>> best, >>>> >>>> neal >>>> >>>> >>>> >>>> On Tue, Mar 12, 2019 at 10:09 PM Jared Newman wro= te: >>>>> >>>>> Hey BBR-dev, >>>>> >>>>> I'm trying to apply the patches given in https://groups.google.com/fo= rum/#!topic/bbr-dev/8pgyOyUavvY, but am struggling to find what commit of n= ext-net I should apply them on. I tried a couple different tags in https://= git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git but would always= get conflicts that I didn't feel comfortable resolving. Does anyone have a= suggestion / commit hash to apply them to? >>>>> >>>>> Cheers, >>>>> Jared. >>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google Gr= oups "BBR Development" group. >>>>> To unsubscribe from this group and stop receiving emails from it, sen= d an email to bbr-dev+u...@googlegroups.com. >>>>> For more options, visit https://groups.google.com/d/optout. >>> >>> -- >>> You received this message because you are subscribed to the Google Grou= ps "BBR Development" group. >>> To unsubscribe from this group and stop receiving emails from it, send = an email to bbr-dev+u...@googlegroups.com. >>> For more options, visit https://groups.google.com/d/optout. > > -- > You received this message because you are subscribed to the Google Groups= "BBR Development" group. > To unsubscribe from this group and stop receiving emails from it, send an= email to bbr-dev+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. --=20 Dave T=C3=A4ht CTO, TekLibre, LLC http://www.teklibre.com Tel: 1-831-205-9740