From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 32C7D3B29E for ; Thu, 19 Mar 2020 18:21:40 -0400 (EDT) Received: by mail-io1-xd34.google.com with SMTP id e20so3635102ios.12 for ; Thu, 19 Mar 2020 15:21:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-transfer-encoding; bh=/M+bRDdUrvM4P44vIeiTvNtnyMFsXisFiMl+0kBHRXw=; b=ZpYnnKdNYawaS5AX1O8yWLlBypwSQ4V08GoYdSYXxe8FXIaK3ewb87qieLZe1rm7xT RSbawFGc+tTo89aGZk43VWck52OAFb7CG1GuKHAWZAFCbpDk0SuEotcFqYpJJ7t2bipZ iW6S7fKotMhxaRI6oKJuFniS4Y1wuHszDQLd3GMZdFLOKD3U8gOy1NmwPDF+sS2dQF7m gyC6uh0n06gDBenoNTDpSpmsREw1HYe08vf1p/Nh8n1yVu4hHuueouWZiI2+q78sm8Cn MqKQ2lwfbviFWPXKEW7Et7KeAHeBVvkXtYKUYNy77+6zncGOqk7To8BQ7ZnD1mkV3K7s 07eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:content-transfer-encoding; bh=/M+bRDdUrvM4P44vIeiTvNtnyMFsXisFiMl+0kBHRXw=; b=FVHmbK3IeQOnSNF3ETpfxjAPJ4ve8STAn1NWyHJez77d+lGoazKbYywGiAckfaNbgY V1CoAh2i8rrGolvBwD3UFSL9dDGdgjGr455TIFlabXJwkpV9YGGG9btek0TBu0oqPk88 Olad8Syfem/g9mPTAAWmlG1Vgp/rRgFsv3Txi+QvGMwHGHwsu5h5iDWE497zcDT6U6yP R4RO15IF+NMXatofMwIRh4QFuxj6It5sLwaIaifsyRBV9pKae6iTPknD7zBemZ1iIa/D d8ImAPl4kpRkUTqL8NHzRlnNu7TKdKfJ1O0nrn6aZfKZexYR6tjQEqkS5rQVgB4P+fDc 4PQw== X-Gm-Message-State: ANhLgQ1Vcz+PELUKD20MLh4wN9Hw8DWCpRaD1Bx8AD7xIPP883WGz2Ik BnUoJfAqhUsZEeDPas8gcAmpoKVMk+tdLfsl8KnuQtZm X-Google-Smtp-Source: ADFU+vvL9Qbj0SFuVUBTRw3uLzPZ6mdrSa5jgtK8pQdOgEUK90P0bCVp4OWTojHzgc1GBDIFKiQfNYuM9YZV1I7NqzA= X-Received: by 2002:a02:856a:: with SMTP id g97mr5214410jai.97.1584656499614; Thu, 19 Mar 2020 15:21:39 -0700 (PDT) MIME-Version: 1.0 References: <1584524612-24470-1-git-send-email-ilpo.jarvinen@helsinki.fi> In-Reply-To: <1584524612-24470-1-git-send-email-ilpo.jarvinen@helsinki.fi> From: Dave Taht Date: Thu, 19 Mar 2020 15:21:28 -0700 Message-ID: To: ECN-Sane Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: [Ecn-sane] Fwd: [RFC PATCH 00/28]: Accurate ECN for TCP X-BeenThere: ecn-sane@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussion of explicit congestion notification's impact on the Internet List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Mar 2020 22:21:40 -0000 I have no comments to make, aside from my concerns with dealing correctly with offload engines. ---------- Forwarded message --------- From: Ilpo J=C3=A4rvinen Date: Wed, Mar 18, 2020 at 2:45 AM Subject: [RFC PATCH 00/28]: Accurate ECN for TCP To: Cc: Yuchung Cheng , Neal Cardwell , Eric Dumazet , Olivier Tilmans Hi all, Here's the full Accurate ECN implementation mostly based on https://tools.ietf.org/html/draft-ietf-tcpm-accurate-ecn-11 Comments would be highly appreciated. The GSO/TSO maze of bits in particular is something I'm somewhat unsure if I got it right (for a feature that has a software fallback). There is an extensive set of packetdrill unit tests for most of the functionality (I'll send separately to packetdrill). Please note that this submission is not yet intented to be included to net-next because some small changes seem still possible to the spec. Documentation/networking/ip-sysctl.txt | 12 +- drivers/net/tun.c | 3 +- include/linux/netdev_features.h | 3 + include/linux/skbuff.h | 2 + include/linux/tcp.h | 19 ++ include/net/tcp.h | 221 ++++++++++--- include/uapi/linux/tcp.h | 9 +- net/ethtool/common.c | 1 + net/ipv4/bpf_tcp_ca.c | 2 +- net/ipv4/syncookies.c | 12 + net/ipv4/tcp.c | 10 +- net/ipv4/tcp_dctcp.c | 2 +- net/ipv4/tcp_dctcp.h | 2 +- net/ipv4/tcp_input.c | 558 ++++++++++++++++++++++++++++-= ---- net/ipv4/tcp_ipv4.c | 8 +- net/ipv4/tcp_minisocks.c | 84 ++++- net/ipv4/tcp_offload.c | 11 +- net/ipv4/tcp_output.c | 298 +++++++++++++++--- net/ipv4/tcp_timer.c | 4 +- net/ipv6/syncookies.c | 1 + net/ipv6/tcp_ipv6.c | 4 +- net/netfilter/nf_log_common.c | 4 +- -- i. ps. My apologies if you got a duplicate copy of them. It seems that answering "no" to git send-email asking "Send this email?" might still have sent something out. --=20 Make Music, Not War Dave T=C3=A4ht CTO, TekLibre, LLC http://www.teklibre.com Tel: 1-831-435-0729