From: Dave Taht <dave.taht@gmail.com>
To: libreqos@lists.bufferbloat.net
Subject: [LibreQoS] Fwd: xmit_more?
Date: Mon, 17 Oct 2022 12:05:20 -0700 [thread overview]
Message-ID: <CAA93jw5UfWzhynHiW53QP2kOEyvBwzMwQmtSXMtM9vGrP7hXQQ@mail.gmail.com> (raw)
In-Reply-To: <CADRO9jNC9Z+zkv7E5mwPP-gcb74oEYyRdd2B7dxCMOhibucOJA@mail.gmail.com>
I was looking over some very old work, here: https://lwn.net/Articles/615238/
about BQL and xmit_more in the context of the mvpp2 work going on over here:
https://forum.openwrt.org/t/add-support-for-mikrotik-rb5009ug/104391/831
Courtesy, jesper:
"I'm on PTO and traveling, so i don't have access to my bpftrace
scripts (here from the hotel lobby).
And yes I usually just "code" a oneliner with bpftrace to measure the
bulking effect.
I coded the qdisc tx bulking and added a tracepoint for this purpose.
You can also use the pktgen scripts in samples/pktgen/ 03 to burst
packets to see the xmit more effect."
--Jesper
man. 17. okt. 2022 16.40 skrev Toke Høiland-Jørgensen <toke@redhat.com>:
>
> Dave Taht <dave.taht@gmail.com> writes:
>
> > On Mon, Oct 17, 2022 at 7:00 AM Toke Høiland-Jørgensen <toke@redhat.com> wrote:
> >>
> >> Dave Taht <dave.taht@gmail.com> writes:
> >>
> >> > This is an old blog from jesper from ages back. Is xmit_more on on
> >> > most drivers nowadays? Was it subsumed by something else?
> >>
> >> Definitely still a thing. As for driver support:
> >
> > Well, marcin just added bql support to the mvpp2, but not xmit_more,
> > apparently. He's still working out
> > ways to measure the improvement better, but it did work correctly in
> > the openwrt 5.15 build.
> >
> > There a good way to see xmit_more doing magic?
>
> Jesper has a bpftrace invocation that spits out a nice histogram (for
> both BQL and xmit_more). Hopefully he's willing to share that ;)
>
> -Toke
>
--
This song goes out to all the folk that thought Stadia would work:
https://www.linkedin.com/posts/dtaht_the-mushroom-song-activity-6981366665607352320-FXtz
Dave Täht CEO, TekLibre, LLC
parent reply other threads:[~2022-10-17 19:05 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CADRO9jNC9Z+zkv7E5mwPP-gcb74oEYyRdd2B7dxCMOhibucOJA@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/libreqos.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA93jw5UfWzhynHiW53QP2kOEyvBwzMwQmtSXMtM9vGrP7hXQQ@mail.gmail.com \
--to=dave.taht@gmail.com \
--cc=libreqos@lists.bufferbloat.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox