From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 2ED3C3B2A4 for ; Mon, 17 Oct 2022 15:05:35 -0400 (EDT) Received: by mail-wm1-x32a.google.com with SMTP id az22-20020a05600c601600b003c6b72797fdso10685782wmb.5 for ; Mon, 17 Oct 2022 12:05:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mnNlLuPaTAjnTkoV0LeVkjP4e0r8ktrSews1vL10h+g=; b=kBff0Y/xv7jlAL5Dt0979AxNdlDiRDgHZ1Lv1+YSwb0v4yceVIfl+wbFNWPrPCT3R2 IxstLAiQ/dZg+IaPLHsYDKkiFmRAlQ4SyV23/7V4Ohx9N1RuDaP+s8vmaGy59Y/CTUww WnWPHf++9icyHQ+YiUzAyJ2gnxDJ3BCF1CuxUdTrS/XwrrigLBXgj3k9mfjG/H2yU+Ht jfa6DBgBpONSnZnvFXw4Duz6+LdAKAXrOQxxr7D74v4ETEteXyaG8FvXj5D63mH6eddQ ojh+39CMxmkBKITKTRPU0O7xPPdCKtJT4B/hGncBCuSelbwKb5FYVlVWHwPL1lMYuiD3 5sSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mnNlLuPaTAjnTkoV0LeVkjP4e0r8ktrSews1vL10h+g=; b=JlUuwNE4K2fkwk3KunNwJPmUVfJUZohnBF9tPEyZlvxDBUgaHUDoFcpbl6KMzsfg6A pjRlRbUvUoq7mUhd8I8HsVvKY/avje7mZs9Gi181ugqQNbgTA2rBKlq+VSPnC8+TKA26 zA/k3TxqbSPFazh6YLGkET1Cb63gzUEH06+rOzKr0Hx0rd4O3eA9v/uzdstxaCxE/D0Z uQZKMCzyeEO8K7SoW1ePoiCMWH9XMK8Tv+p4dlvJA6tV3+CX8zDPHCweBBtMPJCOkTIX lJyUJyubOpFEAuSa7JjNRYNQ7JENXnzfz/3Af4vxgaYUXTJAkdqFfpMrIlLs2RMFL5Me H6BA== X-Gm-Message-State: ACrzQf11TZz9XsQWqKwfwjGO3KkbgwXHqjt+kr7EcT80WPNw5xvVfnum LOINT2xont0pyuhA7rnEiRxLylSW+mEpeI4fT6rcZNp520U= X-Google-Smtp-Source: AMsMyM4OzP0xTRZvIPk1KiTrfS6oB/ltU+RDnEY2pIvtiRnXwmonq9uuarnolFkxAdL1UlMJgTeGo64QseLxYy8b82w= X-Received: by 2002:a05:600c:54f2:b0:3c6:bd60:5390 with SMTP id jb18-20020a05600c54f200b003c6bd605390mr20144680wmb.206.1666033533631; Mon, 17 Oct 2022 12:05:33 -0700 (PDT) MIME-Version: 1.0 References: <87edv6turu.fsf@toke.dk> <875ygitswh.fsf@toke.dk> In-Reply-To: From: Dave Taht Date: Mon, 17 Oct 2022 12:05:20 -0700 Message-ID: To: libreqos@lists.bufferbloat.net Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: [LibreQoS] Fwd: xmit_more? X-BeenThere: libreqos@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: Many ISPs need the kinds of quality shaping cake can do List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2022 19:05:35 -0000 I was looking over some very old work, here: https://lwn.net/Articles/61523= 8/ about BQL and xmit_more in the context of the mvpp2 work going on over her= e: https://forum.openwrt.org/t/add-support-for-mikrotik-rb5009ug/104391/831 Courtesy, jesper: "I'm on PTO and traveling, so i don't have access to my bpftrace scripts (here from the hotel lobby). And yes I usually just "code" a oneliner with bpftrace to measure the bulking effect. I coded the qdisc tx bulking and added a tracepoint for this purpose. You can also use the pktgen scripts in samples/pktgen/ 03 to burst packets to see the xmit more effect." --Jesper man. 17. okt. 2022 16.40 skrev Toke H=C3=B8iland-J=C3=B8rgensen : > > Dave Taht writes: > > > On Mon, Oct 17, 2022 at 7:00 AM Toke H=C3=B8iland-J=C3=B8rgensen wrote: > >> > >> Dave Taht writes: > >> > >> > This is an old blog from jesper from ages back. Is xmit_more on on > >> > most drivers nowadays? Was it subsumed by something else? > >> > >> Definitely still a thing. As for driver support: > > > > Well, marcin just added bql support to the mvpp2, but not xmit_more, > > apparently. He's still working out > > ways to measure the improvement better, but it did work correctly in > > the openwrt 5.15 build. > > > > There a good way to see xmit_more doing magic? > > Jesper has a bpftrace invocation that spits out a nice histogram (for > both BQL and xmit_more). Hopefully he's willing to share that ;) > > -Toke > --=20 This song goes out to all the folk that thought Stadia would work: https://www.linkedin.com/posts/dtaht_the-mushroom-song-activity-69813666656= 07352320-FXtz Dave T=C3=A4ht CEO, TekLibre, LLC