Many ISPs need the kinds of quality shaping cake can do
 help / color / mirror / Atom feed
From: Dave Taht <dave.taht@gmail.com>
To: libreqos <libreqos@lists.bufferbloat.net>
Subject: [LibreQoS] Fwd: [RFC PATCH v3 0/3] io_uring: add napi busy polling support
Date: Wed, 16 Nov 2022 12:14:02 -0800	[thread overview]
Message-ID: <CAA93jw5cDk_xKXOE032OxUDrYvhz8S5EuXQhu9MhvwovtH2m9g@mail.gmail.com> (raw)
In-Reply-To: <20221115070900.1788837-1-shr@devkernel.io>

[-- Attachment #1: Type: text/plain, Size: 2210 bytes --]

---------- Forwarded message ---------
From: Stefan Roesch <shr@devkernel.io>
Date: Mon, Nov 14, 2022, 11:13 PM
Subject: [RFC PATCH v3 0/3] io_uring: add napi busy polling support
To: <kernel-team@fb.com>
Cc: <shr@devkernel.io>, <axboe@kernel.dk>, <olivier@trillion01.com>, <
netdev@vger.kernel.org>, <io-uring@vger.kernel.org>, <kuba@kernel.org>


This adds the napi busy polling support in io_uring.c. It adds a new
napi_list to the io_ring_ctx structure. This list contains the list of
napi_id's that are currently enabled for busy polling. This list is
used to determine which napi id's enabled busy polling.

To set the new napi busy poll timeout, a new io-uring api has been
added. It sets the napi busy poll timeout for the corresponding ring.

There is also a corresponding liburing patch series, which enables this
feature. The name of the series is "liburing: add add api for napi busy
poll timeout". It also contains two programs to test the this.

Testing has shown that the round-trip times are reduced to 38us from
55us by enabling napi busy polling with a busy poll timeout of 100us.


Changes:
- V3:
  - Refreshed to 6.1-rc5
  - Added a new io-uring api for the prefer napi busy poll api and wire
    it to io_napi_busy_loop().
  - Removed the unregister (implemented as register)
  - Added more performance results to the first commit message.
- V2:
  - Add missing defines if CONFIG_NET_RX_BUSY_POLL is not defined
  - Changes signature of function io_napi_add_list to static inline
    if CONFIG_NET_RX_BUSY_POLL is not defined
  - define some functions as static


Signed-off-by: Stefan Roesch <shr@devkernel.io>

Stefan Roesch (3):
  io_uring: add napi busy polling support
  io_uring: add api to set napi busy poll timeout.
  io_uring: add api to set napi prefer busy poll

 include/linux/io_uring_types.h |   8 +
 include/uapi/linux/io_uring.h  |   4 +
 io_uring/io_uring.c            | 278 +++++++++++++++++++++++++++++++++
 io_uring/napi.h                |  22 +++
 io_uring/poll.c                |   3 +
 io_uring/sqpoll.c              |  10 ++
 6 files changed, 325 insertions(+)
 create mode 100644 io_uring/napi.h


base-commit: 094226ad94f471a9f19e8f8e7140a09c2625abaa
-- 
2.30.2

[-- Attachment #2: Type: text/html, Size: 3199 bytes --]

           reply	other threads:[~2022-11-16 20:14 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20221115070900.1788837-1-shr@devkernel.io>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/libreqos.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA93jw5cDk_xKXOE032OxUDrYvhz8S5EuXQhu9MhvwovtH2m9g@mail.gmail.com \
    --to=dave.taht@gmail.com \
    --cc=libreqos@lists.bufferbloat.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox