Many ISPs need the kinds of quality shaping cake can do
 help / color / mirror / Atom feed
From: Dave Taht <dave.taht@gmail.com>
To: libreqos <libreqos@lists.bufferbloat.net>
Subject: [LibreQoS] Fwd: you guys got any favorite flame graphs?
Date: Fri, 16 Dec 2022 07:16:25 -0800	[thread overview]
Message-ID: <CAA93jw7ASsP=xkJCQEOq4LoOkVVgHHJ6twQSOC-kDwCmV96uVQ@mail.gmail.com> (raw)
In-Reply-To: <87a63nbdm6.fsf@toke.dk>

---------- Forwarded message ---------
From: Toke Høiland-Jørgensen <toke@redhat.com>



Dave Taht <dave.taht@gmail.com> writes:

> Is it a delusional dream to want to poll tc -s qdisc show of 40k
> instances of cake on a htb tree every 10ms?
>
> presently 10k takes about 290us (locked to one cpu), and I have no
> idea what to look for while doing that.

So that's dumping all of them sequentially? In a single dump call from
the root, or multiple calls? Assuming sequentially, that works out to 29
nanoseconds per instance, which I'd say that was pretty good...

Looks like Eric already optimised the stat dumping in:

edb09eb17ed8 ("net: sched: do not acquire qdisc spinlock in
qdisc/class stats dump")

So it doesn't take the qdisc lock at all, unless you're also dumping the
class (per-flow) stats in the case of sch_cake.

As a side note, this may mean that the cake stats can suffer from
load tearing on 32-bit systems, since it's just doing a regular
unprotected read of everything, including the 64-bit counters...

-Toke



-- 
This song goes out to all the folk that thought Stadia would work:
https://www.linkedin.com/posts/dtaht_the-mushroom-song-activity-6981366665607352320-FXtz
Dave Täht CEO, TekLibre, LLC

           reply	other threads:[~2022-12-16 15:16 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <87a63nbdm6.fsf@toke.dk>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/libreqos.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAA93jw7ASsP=xkJCQEOq4LoOkVVgHHJ6twQSOC-kDwCmV96uVQ@mail.gmail.com' \
    --to=dave.taht@gmail.com \
    --cc=libreqos@lists.bufferbloat.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox