From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nbd.name (nbd.name [IPv6:2a01:4f8:131:30e2::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 12DFC3B25D for ; Fri, 8 Jul 2016 12:10:16 -0400 (EDT) To: =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= , Kalle Valo References: <87wpkwktx9.fsf@toke.dk> Cc: linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net, ath9k-devel@lists.ath9k.org, Tim Shepard From: Felix Fietkau Message-ID: <112300e0-7d39-0c4c-45c9-158651f0c0ed@nbd.name> User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <87wpkwktx9.fsf@toke.dk> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Mailman-Approved-At: Mon, 28 Nov 2016 08:47:10 -0500 Subject: Re: [Make-wifi-fast] [v3] ath9k: Switch to using mac80211 intermediate software queues. X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Fri, 08 Jul 2016 16:10:17 -0000 X-Original-Date: Fri, 8 Jul 2016 18:10:11 +0200 X-List-Received-Date: Fri, 08 Jul 2016 16:10:17 -0000 On 2016-07-08 17:53, Toke Høiland-Jørgensen wrote: > Kalle Valo writes: > >> Toke Høiland-Jørgensen wrote: >>> This switches ath9k over to using the mac80211 intermediate software >>> queueing mechanism for data packets. It removes the queueing inside the >>> driver, except for the retry queue, and instead pulls from mac80211 when >>> a packet is needed. The retry queue is used to store a packet that was >>> pulled but can't be sent immediately. >>> >>> The old code path in ath_tx_start that would queue packets has been >>> removed completely, as has the qlen limit tunables (since there's no >>> longer a queue in the driver to limit). >>> >>> Based on Tim's original patch set, but reworked quite thoroughly. >>> >>> Cc: Tim Shepard >>> Cc: Felix Fietkau >>> Signed-off-by: Toke Høiland-Jørgensen >> >> Nice work. > > Thanks :) > >> Because this is such a significant change, and to maximise testing >> time, I'm planning to queue this for 4.9 (so I would apply this to >> ath-next in 3-4 weeks after the merge window closes). But anyone who >> wants to test this can use master-pending branch from my ath.git tree >> (uses wireless-testing as the baseline). Sounds good? > > Sounds good to me. I'm planning on backporting this and Michael's > mac80211 FQ-CoDel patches to 4.4 and post them for inclusion in LEDE. > Hopefully that will get it some more testing as well. I've pushed a backport of this into my LEDE staging tree: https://git.lede-project.org/?p=lede/nbd/staging.git;a=summary I don't have time for testing it myself at the moment, but I'll try to get some people to do so. - Felix