From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id EAE5E3CB36 for ; Mon, 17 Sep 2018 20:57:35 -0400 (EDT) Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 24E926028D; Tue, 18 Sep 2018 00:57:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1537232255; bh=Hv8ulvJa9PmqKJbNipE7/ftMzdij4YKO3aFHJWapzsE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jRRh+lYMI7vQgSUMXAIkZK+wSJ2xrRQK9gy+2lXmmVJTtDcDGmG9ZkZWhBPCUBeOx uIt+dhQ1CTED1Fc3vilzs8VSu6z412NorLCgKuDUGvcevwoUACCLH9Ngfv4WedvhJa why+B8gdDLYGWgE2BUl7V+qu/bBJ2MQ2YB0LoZLc= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id BA3FE60818; Tue, 18 Sep 2018 00:57:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1537232254; bh=Hv8ulvJa9PmqKJbNipE7/ftMzdij4YKO3aFHJWapzsE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GpwaIEG3I4s44xRQgL3Wco70ANYkDFSwUI3Vyq1iJeY8DO0IFpY1yz+lyKYYvx+RP QctUQvuZkttAaCeQxpQlLliiaEDDl0ejFkxSLMyAZO5Xm5lyJS49vqGc13dQADymXi MJZpio0zLKIYrBmn20UMviJoHBgooTI0pcuIKFLQ= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Mon, 17 Sep 2018 17:57:34 -0700 From: Rajkumar Manoharan To: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Cc: linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net, Felix Fietkau , Kan Yan , linux-wireless-owner@vger.kernel.org In-Reply-To: <153711973109.9231.7094211814263758096.stgit@alrua-x1.karlstad.toke.dk> References: <153711966150.9231.13481453399723518107.stgit@alrua-x1> <153711973109.9231.7094211814263758096.stgit@alrua-x1.karlstad.toke.dk> Message-ID: <13400b5f9bdb5e36c6afabd071cc7b0d@codeaurora.org> X-Sender: rmanohar@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Subject: Re: [Make-wifi-fast] [PATCH RFC v4 1/4] mac80211: Add TXQ scheduling API X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Sep 2018 00:57:36 -0000 On 2018-09-16 10:42, Toke Høiland-Jørgensen wrote: > +/** > + * ieee80211_return_txq - return a TXQ previously acquired by > ieee80211_next_txq() > + * > + * @hw: pointer as obtained from ieee80211_alloc_hw() > + * @txq: pointer obtained from station or virtual interface > + * > + * Should only be called between calls to > ieee80211_txq_schedule_start() > + * and ieee80211_txq_schedule_end(). > + */ > +void ieee80211_return_txq(struct ieee80211_hw *hw, struct > ieee80211_txq *txq); > + > return_txq() should return a bool to inform the driver that whether txq is queued back or not. Otherwise the same txq will be served indefinitely until txq becomes empty. This problem occurs when the driver is running out of hw descriptors or driver sends only N frames (< backlog_packets). Also an option to add the node at head or tail would be preferred. If return_txq adds node at head of list, then it is forcing the driver to serve same txq until it becomes empty. Also this will not allow the driver to send N frames from each txqs. > +/** > + * ieee80211_txq_schedule_start - acquire locks for safe scheduling of > an AC > + * > + * @hw: pointer as obtained from ieee80211_alloc_hw() > + * @ac: AC number to acquire locks for > + * > + * Acquire locks needed to schedule TXQs from the given AC. Should be > called > + * before ieee80211_next_txq() or ieee80211_schedule_txq(). > + */ Typo error. s/schedule_txq()/return_txq()/. -Rajkumar