From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <johannes@sipsolutions.net>
Received: from sipsolutions.net (s3.sipsolutions.net [5.9.151.49])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id 53C6A3B2CD;
 Thu,  7 Apr 2016 04:53:50 -0400 (EDT)
Received: by sipsolutions.net with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87)
 (envelope-from <johannes@sipsolutions.net>)
 id 1ao5hC-0004mw-Vf; Thu, 07 Apr 2016 10:53:47 +0200
Message-ID: <1460019225.27154.5.camel@sipsolutions.net>
From: Johannes Berg <johannes@sipsolutions.net>
To: Dave Taht <dave.taht@gmail.com>
Cc: Michal Kazior <michal.kazior@tieto.com>, linux-wireless
 <linux-wireless@vger.kernel.org>, make-wifi-fast@lists.bufferbloat.net, 
 "codel@lists.bufferbloat.net" <codel@lists.bufferbloat.net>
Date: Thu, 07 Apr 2016 10:53:45 +0200
In-Reply-To: <CAA93jw5mTMndywTH7GRqKMPr24UhxN8m0i0ri4dXa4ZdCULEoQ@mail.gmail.com>
 (sfid-20160406_193938_584462_320BAA37)
References: <1458898052-20601-1-git-send-email-michal.kazior@tieto.com>
 <1459420104-31554-1-git-send-email-michal.kazior@tieto.com>
 <1459420104-31554-2-git-send-email-michal.kazior@tieto.com>
 <1459864656.18188.60.camel@sipsolutions.net>
 <CAA93jw4Swv9aOr=ZKoKeQyp9f1HnYJtiY7a1Lw2Ri89XjGiORQ@mail.gmail.com>
 <1459927276.17504.6.camel@sipsolutions.net>
 <CAA93jw5mTMndywTH7GRqKMPr24UhxN8m0i0ri4dXa4ZdCULEoQ@mail.gmail.com>
 (sfid-20160406_193938_584462_320BAA37)
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.18.5.1-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Make-wifi-fast] [PATCHv2 1/2] mac80211: implement fair queuing
	per txq
X-BeenThere: make-wifi-fast@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: <make-wifi-fast.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/make-wifi-fast>,
 <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/make-wifi-fast>
List-Post: <mailto:make-wifi-fast@lists.bufferbloat.net>
List-Help: <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/make-wifi-fast>,
 <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Thu, 07 Apr 2016 08:53:50 -0000

On Wed, 2016-04-06 at 10:39 -0700, Dave Taht wrote:

> > > The hope had been the original codel.h would have been reusable,
> > > which is not the case at present.
> > So what's the strategy for making it happen?
> Strategy? to meander towards a result that gives low latency to all
> stations, no matter their bandwidth, on several chipsets.

I meant "strategy for making the code reusable". Or something like that
anyway. I don't see the point in trying and then failing. Here we're
adding a completely different version of codel to the kernel - why?
What makes this version unusable for the original usage in
include/net/codel.h? Can't we replace that one with the newer version
and actually use the same file here?

Or - why bother with the header file to make it shareable, if we're not
even attempting to do that?

johannes