From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <johannes@sipsolutions.net>
Received: from sipsolutions.net (s3.sipsolutions.net [5.9.151.49])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id 2370D3B484;
 Sat, 16 Apr 2016 18:21:11 -0400 (EDT)
Received: by sipsolutions.net with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87)
 (envelope-from <johannes@sipsolutions.net>)
 id 1arYaS-0007gX-K4; Sun, 17 Apr 2016 00:21:08 +0200
Message-ID: <1460845267.2075.26.camel@sipsolutions.net>
From: Johannes Berg <johannes@sipsolutions.net>
To: Michal Kazior <michal.kazior@tieto.com>, linux-wireless@vger.kernel.org
Cc: dave.taht@gmail.com, make-wifi-fast@lists.bufferbloat.net, 
 codel@lists.bufferbloat.net, apenwarr@gmail.com
Date: Sun, 17 Apr 2016 00:21:07 +0200
In-Reply-To: <1460636302-31161-2-git-send-email-michal.kazior@tieto.com>
 (sfid-20160414_141628_659448_D3FFFECB)
References: <1459420104-31554-1-git-send-email-michal.kazior@tieto.com>
 <1460636302-31161-1-git-send-email-michal.kazior@tieto.com>
 <1460636302-31161-2-git-send-email-michal.kazior@tieto.com>
 (sfid-20160414_141628_659448_D3FFFECB)
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.18.5.1-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [Make-wifi-fast] [PATCHv3 1/5] mac80211: skip netdev queue
 control with software queuing
X-BeenThere: make-wifi-fast@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: <make-wifi-fast.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/make-wifi-fast>,
 <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/make-wifi-fast>
List-Post: <mailto:make-wifi-fast@lists.bufferbloat.net>
List-Help: <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/make-wifi-fast>,
 <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Sat, 16 Apr 2016 22:21:11 -0000

> +static void ieee80211_txq_enqueue(struct ieee80211_local *local,
> +				  struct txq_info *txqi,
> +				  struct sk_buff *skb)
> +{
> +	lockdep_assert_held(&txqi->queue.lock);
[...]
> +	atomic_inc(&local->num_tx_queued);

This global kinda bothers me - anything we can do about removing it?

We obviously didn't have it now - just one (even bigger limit!) per
queue, so that's 4000 frames default per interface ... now you're down
to 512 for the entire hardware. Perhaps keeping it per interface at
least gets away the worst of the contention here?

johannes