From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-x229.google.com (mail-pf0-x229.google.com [IPv6:2607:f8b0:400e:c00::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id D8A353B2C5; Mon, 18 Apr 2016 08:31:14 -0400 (EDT) Received: by mail-pf0-x229.google.com with SMTP id n1so80670275pfn.2; Mon, 18 Apr 2016 05:31:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=fSA4raMSX7ZN+zi+3+9Yk9buSBCUoLFpNybd1P86Rs8=; b=RbzPppZBlNYezemM8WqcwaJhoZzIr6uURRtjYzco4QZB+e1h4rk39Hvu2kli2GOhTt GoggvdK58tT0wm5N+CWDF9AgnTlFl2H0RcwIeovwO4T/z1s0wA8CvzJJe5YrGCA+1qww vh+euVYITWkaKDbOYZyxfOpRnKmH8gW1iYJqQxJ9gjsVfjLgRoTVkDBdmCyow+QNfRL0 2cyT0OpbFkFjJQ0EZhtNwDLJMMWLuoVeecKq79vWJIclPsbBf/qemns7CZpot99JWzD8 +B+iNQtRIjVQUTVubIxwss7WhSuPoOir3WNbBRdisxZk+rW3i1ArbYssNIztxT5Lxj7I qHjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=fSA4raMSX7ZN+zi+3+9Yk9buSBCUoLFpNybd1P86Rs8=; b=bcgAsrH95pWkle2s13SFgN9Z+M6Tod2sUHNChIP4DXdD286yOJ+2zmT5tsb/Yq5RpC JnmrnPL5kfsaWrWB6qB1pMHsnBOaGSadhvYs+JIJLGdr7f7qCjvhZKorDSqw4Ob6xx5N wJjdG6YMx53mHfITYnLUJ9iFk9shgTf32oBHStvmYtDWuktAsW+I1cgjWxGz3BDOzjnJ JIvbJ4ub95A0o49JE6yKUDIoKn99AUnvGZQ+VkYqoFatySCWD6CATZ+5Do6SEDxtarDT x1wfQa+yaDYlzuxRYJDJW8AkvvnDeSYoE2KdRm/4lV12VGcvpdnjg+p9TjUlngRhuuYt VxDg== X-Gm-Message-State: AOPr4FU7zmyGfYurJ1fN/IKPlFtJvjNypCW/L/JcszfN0pzM+loSDc4mSWgUw+fWNeRQXQ== X-Received: by 10.98.53.6 with SMTP id c6mr48702471pfa.57.1460982674127; Mon, 18 Apr 2016 05:31:14 -0700 (PDT) Received: from [192.168.86.171] (c-73-231-122-98.hsd1.ca.comcast.net. [73.231.122.98]) by smtp.googlemail.com with ESMTPSA id m186sm22845529pfm.29.2016.04.18.05.31.13 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 18 Apr 2016 05:31:13 -0700 (PDT) Message-ID: <1460982672.10638.111.camel@edumazet-glaptop3.roam.corp.google.com> From: Eric Dumazet To: Michal Kazior Cc: Johannes Berg , make-wifi-fast@lists.bufferbloat.net, linux-wireless , codel@lists.bufferbloat.net, Avery Pennarun Date: Mon, 18 Apr 2016 05:31:12 -0700 In-Reply-To: References: <1459420104-31554-1-git-send-email-michal.kazior@tieto.com> <1460636302-31161-1-git-send-email-michal.kazior@tieto.com> <1460636302-31161-3-git-send-email-michal.kazior@tieto.com> <1460845384.2075.27.camel@sipsolutions.net> <1460845552.2075.28.camel@sipsolutions.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Mon, 02 May 2016 15:49:25 -0400 Subject: Re: [Make-wifi-fast] [Codel] [PATCHv3 2/5] mac80211: implement fair queueing per txq X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2016 12:31:15 -0000 On Mon, 2016-04-18 at 07:16 +0200, Michal Kazior wrote: > > I guess .h file can give the compiler an opportunity for more > optimizations. With .c you would need LTO which I'm not sure if it's > available everywhere. > This makes little sense really. Otherwise everything would be in .h files. include/net/codel.h is an include file because both codel and fq_codel use a common template for codel_dequeue() in fast path. But net/mac80211/fq.h is included once, so should be a .c Certainly all the code in control plan is not fast path and does not deserve being duplicated.