From: Michal Kazior <michal.kazior@tieto.com>
To: linux-wireless@vger.kernel.org
Cc: johannes@sipsolutions.net, dave.taht@gmail.com,
make-wifi-fast@lists.bufferbloat.net, apenwarr@gmail.com,
Michal Kazior <michal.kazior@tieto.com>
Subject: [Make-wifi-fast] [PATCHv5 5/5] mac80211: add debug knobs for codel
Date: Thu, 19 May 2016 10:37:52 +0200 [thread overview]
Message-ID: <1463647072-16201-6-git-send-email-michal.kazior@tieto.com> (raw)
In-Reply-To: <1463647072-16201-1-git-send-email-michal.kazior@tieto.com>
This adds a few debugfs entries to make it easier
to test, debug and experiment.
Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
---
Notes:
v5:
* use the single "aqm" debugfs knob [Dave]
v4:
* stats adjustments (in-kernel codel has more of them)
net/mac80211/debugfs.c | 33 +++++++++++++++++++++++++++++++--
1 file changed, 31 insertions(+), 2 deletions(-)
diff --git a/net/mac80211/debugfs.c b/net/mac80211/debugfs.c
index 2906c1004e1a..53a315401a4b 100644
--- a/net/mac80211/debugfs.c
+++ b/net/mac80211/debugfs.c
@@ -126,13 +126,31 @@ static int aqm_open(struct inode *inode, struct file *file)
"R fq_overlimit %u\n"
"R fq_collisions %u\n"
"RW fq_limit %u\n"
- "RW fq_quantum %u\n",
+ "RW fq_quantum %u\n"
+ "R codel_maxpacket %u\n"
+ "R codel_drop_count %u\n"
+ "R codel_drop_len %u\n"
+ "R codel_ecn_mark %u\n"
+ "R codel_ce_mark %u\n"
+ "RW codel_interval %u\n"
+ "RW codel_target %u\n"
+ "RW codel_mtu %u\n"
+ "RW codel_ecn %u\n",
fq->flows_cnt,
fq->backlog,
fq->overlimit,
fq->collisions,
fq->limit,
- fq->quantum);
+ fq->quantum,
+ local->cstats.maxpacket,
+ local->cstats.drop_count,
+ local->cstats.drop_len,
+ local->cstats.ecn_mark,
+ local->cstats.ce_mark,
+ local->cparams.interval,
+ local->cparams.target,
+ local->cparams.mtu,
+ local->cparams.ecn ? 1U : 0U);
len += scnprintf(info->buf + len,
info->size - len,
@@ -214,6 +232,7 @@ static ssize_t aqm_write(struct file *file,
struct ieee80211_local *local = info->local;
char buf[100];
size_t len;
+ unsigned int ecn;
if (count > sizeof(buf))
return -EINVAL;
@@ -230,6 +249,16 @@ static ssize_t aqm_write(struct file *file,
return count;
else if (sscanf(buf, "fq_quantum %u", &local->fq.quantum) == 1)
return count;
+ else if (sscanf(buf, "codel_interval %u", &local->cparams.interval) == 1)
+ return count;
+ else if (sscanf(buf, "codel_target %u", &local->cparams.target) == 1)
+ return count;
+ else if (sscanf(buf, "codel_mtu %u", &local->cparams.mtu) == 1)
+ return count;
+ else if (sscanf(buf, "codel_ecn %u", &ecn) == 1) {
+ local->cparams.ecn = !!ecn;
+ return count;
+ }
return -EINVAL;
}
--
2.1.4
next prev parent reply other threads:[~2016-05-19 8:36 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 10:17 [Make-wifi-fast] [RFCv2 0/3] mac80211: implement fq codel Michal Kazior
2016-03-16 10:17 ` [Make-wifi-fast] [RFCv2 1/3] mac80211: implement fq_codel for software queuing Michal Kazior
2016-03-22 1:35 ` David Lang
2016-03-22 6:51 ` Michal Kazior
2016-03-16 10:17 ` [Make-wifi-fast] [RFCv2 2/3] ath10k: report per-station tx/rate rates to mac80211 Michal Kazior
2016-03-24 7:19 ` Mohammed Shafi Shajakhan
2016-03-24 7:49 ` Michal Kazior
2016-03-24 12:23 ` Mohammed Shafi Shajakhan
2016-03-24 12:31 ` Michal Kazior
2016-03-16 10:17 ` [Make-wifi-fast] [RFCv2 3/3] ath10k: use ieee80211_tx_schedule() Michal Kazior
2016-03-16 10:26 ` [Make-wifi-fast] [RFCv2 0/3] mac80211: implement fq codel Michal Kazior
2016-03-16 15:37 ` Dave Taht
2016-03-16 18:36 ` Dave Taht
2016-03-16 18:55 ` Bob Copeland
2016-03-16 19:48 ` Jasmine Strong
2016-03-17 8:55 ` Michal Kazior
2016-03-17 11:12 ` Bob Copeland
2016-03-17 17:00 ` Dave Taht
2016-03-17 17:24 ` [Make-wifi-fast] [Codel] " Rick Jones
2016-03-21 11:57 ` [Make-wifi-fast] " Michal Kazior
2016-03-17 9:43 ` Michal Kazior
2016-03-17 9:03 ` Michal Kazior
2016-03-25 9:27 ` [Make-wifi-fast] [PATCH 0/2] mac80211: implement fq_codel Michal Kazior
2016-03-25 9:27 ` [Make-wifi-fast] [PATCH 1/2] mac80211: implement fair queuing per txq Michal Kazior
[not found] ` <CAHqTa-0yEFYAFpSKyko1ET33GsN==_D8TpBeq6AtwLj4XMTW0A@mail.gmail.com>
2016-04-11 7:25 ` Michal Kazior
2016-03-25 9:27 ` [Make-wifi-fast] [PATCH 2/2] mac80211: expose some txq/fq internals and knobs via debugfs Michal Kazior
2016-03-31 10:28 ` [Make-wifi-fast] [PATCHv2 0/2] mac80211: implement fq_codel Michal Kazior
2016-03-31 10:28 ` [Make-wifi-fast] [PATCHv2 1/2] mac80211: implement fair queuing per txq Michal Kazior
2016-04-05 13:57 ` Johannes Berg
2016-04-05 14:32 ` Dave Taht
[not found] ` <1459927276.17504.6.camel@sipsolutions.net>
2016-04-06 17:39 ` Dave Taht
2016-04-07 8:53 ` Johannes Berg
2016-04-06 5:35 ` Michal Kazior
2016-04-06 6:03 ` Jonathan Morton
2016-04-06 7:16 ` Michal Kazior
2016-04-06 16:46 ` Jonathan Morton
2016-04-06 7:19 ` Johannes Berg
2016-03-31 10:28 ` [Make-wifi-fast] [PATCHv2 2/2] mac80211: expose some txq/fq internals and knobs via debugfs Michal Kazior
2016-04-14 12:18 ` [Make-wifi-fast] [PATCHv3 0/5] mac80211: implement fq_codel Michal Kazior
2016-04-14 12:18 ` [Make-wifi-fast] [PATCHv3 1/5] mac80211: skip netdev queue control with software queuing Michal Kazior
2016-04-16 22:21 ` Johannes Berg
2016-04-18 5:39 ` Michal Kazior
2016-04-14 12:18 ` [Make-wifi-fast] [PATCHv3 2/5] mac80211: implement fair queueing per txq Michal Kazior
2016-04-16 22:23 ` Johannes Berg
2016-04-16 22:25 ` Johannes Berg
2016-04-18 5:16 ` Michal Kazior
2016-04-18 12:31 ` [Make-wifi-fast] [Codel] " Eric Dumazet
2016-04-18 13:36 ` Michal Kazior
2016-04-19 9:10 ` Johannes Berg
2016-04-14 12:18 ` [Make-wifi-fast] [PATCHv3 3/5] mac80211: add debug knobs for fair queuing Michal Kazior
2016-04-14 12:18 ` [Make-wifi-fast] [PATCHv3 4/5] mac80211: implement codel on fair queuing flows Michal Kazior
2016-04-16 22:29 ` Johannes Berg
2016-04-18 5:31 ` Michal Kazior
2016-04-18 12:38 ` Michal Kazior
2016-04-19 9:06 ` Johannes Berg
2016-04-19 9:31 ` Michal Kazior
2016-04-19 9:57 ` Johannes Berg
2016-04-14 12:18 ` [Make-wifi-fast] [PATCHv3 5/5] mac80211: add debug knobs for codel Michal Kazior
2016-05-05 11:00 ` [Make-wifi-fast] [PATCHv4 0/5] mac80211: implement fq_codel Michal Kazior
2016-05-05 11:00 ` [Make-wifi-fast] [PATCHv4 1/5] mac80211: skip netdev queue control with software queuing Michal Kazior
2016-05-09 12:28 ` Michal Kazior
2016-05-05 11:00 ` [Make-wifi-fast] [PATCHv4 2/5] mac80211: implement fair queueing per txq Michal Kazior
2016-05-05 11:00 ` [Make-wifi-fast] [PATCHv4 3/5] mac80211: add debug knobs for fair queuing Michal Kazior
2016-06-09 9:48 ` Johannes Berg
2016-05-05 11:00 ` [Make-wifi-fast] [PATCHv4 4/5] mac80211: implement codel on fair queuing flows Michal Kazior
2016-05-05 15:30 ` Dave Taht
2016-05-05 11:00 ` [Make-wifi-fast] [PATCHv4 5/5] mac80211: add debug knobs for codel Michal Kazior
2016-05-05 15:21 ` Dave Taht
2016-05-06 5:27 ` Michal Kazior
2016-05-06 5:51 ` Dave Taht
2016-05-06 6:33 ` Michal Kazior
2016-05-06 7:23 ` Dave Taht
2016-05-19 8:37 ` [Make-wifi-fast] [PATCHv5 0/5] mac80211: implement fq_codel Michal Kazior
2016-05-19 8:37 ` [Make-wifi-fast] [PATCHv5 1/5] mac80211: skip netdev queue control with software queuing Michal Kazior
2016-05-19 8:37 ` [Make-wifi-fast] [PATCHv5 2/5] mac80211: implement fair queueing per txq Michal Kazior
2016-05-19 8:37 ` [Make-wifi-fast] [PATCHv5 3/5] mac80211: add debug knobs for fair queuing Michal Kazior
2016-05-19 8:37 ` [Make-wifi-fast] [PATCHv5 4/5] mac80211: implement codel on fair queuing flows Michal Kazior
2016-05-19 8:37 ` Michal Kazior [this message]
2016-06-09 9:47 ` [Make-wifi-fast] [PATCHv5 5/5] mac80211: add debug knobs for codel Johannes Berg
2016-05-31 12:12 ` [Make-wifi-fast] [PATCHv5 0/5] mac80211: implement fq_codel Toke Høiland-Jørgensen
2016-05-31 12:31 ` Michal Kazior
2016-06-09 9:49 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/make-wifi-fast.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463647072-16201-6-git-send-email-michal.kazior@tieto.com \
--to=michal.kazior@tieto.com \
--cc=apenwarr@gmail.com \
--cc=dave.taht@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=make-wifi-fast@lists.bufferbloat.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox