From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <johannes@sipsolutions.net>
Received: from sipsolutions.net (s3.sipsolutions.net [5.9.151.49])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id 378B63B25D
 for <make-wifi-fast@lists.bufferbloat.net>;
 Thu,  9 Jun 2016 05:47:59 -0400 (EDT)
Received: by sipsolutions.net with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87)
 (envelope-from <johannes@sipsolutions.net>)
 id 1bAwZA-00016E-VY; Thu, 09 Jun 2016 11:47:57 +0200
Message-ID: <1465465675.3442.8.camel@sipsolutions.net>
From: Johannes Berg <johannes@sipsolutions.net>
To: Michal Kazior <michal.kazior@tieto.com>, linux-wireless@vger.kernel.org
Cc: dave.taht@gmail.com, make-wifi-fast@lists.bufferbloat.net, 
 apenwarr@gmail.com
Date: Thu, 09 Jun 2016 11:47:55 +0200
In-Reply-To: <1463647072-16201-6-git-send-email-michal.kazior@tieto.com>
 (sfid-20160519_103608_366751_6B7E6130)
References: <1462446039-1070-1-git-send-email-michal.kazior@tieto.com>
 <1463647072-16201-1-git-send-email-michal.kazior@tieto.com>
 <1463647072-16201-6-git-send-email-michal.kazior@tieto.com>
 (sfid-20160519_103608_366751_6B7E6130)
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.18.5.1-1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [Make-wifi-fast] [PATCHv5 5/5] mac80211: add debug knobs for
	codel
X-BeenThere: make-wifi-fast@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: <make-wifi-fast.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/make-wifi-fast>,
 <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/make-wifi-fast>
List-Post: <mailto:make-wifi-fast@lists.bufferbloat.net>
List-Help: <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/make-wifi-fast>,
 <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Thu, 09 Jun 2016 09:47:59 -0000


> +++ b/net/mac80211/debugfs.c
> @@ -126,13 +126,31 @@ static int aqm_open(struct inode *inode, struct
> file *file)
>  			 "R fq_overlimit %u\n"
>  			 "R fq_collisions %u\n"
>  			 "RW fq_limit %u\n"
> -			 "RW fq_quantum %u\n",
> +			 "RW fq_quantum %u\n"
> +			 "R codel_maxpacket %u\n"
> +			 "R codel_drop_count %u\n"
> 
It seems to me that this needs to adjust the length of the buffer
that's allocated.

johannes