From: Johannes Berg <johannes@sipsolutions.net>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>,
make-wifi-fast@lists.bufferbloat.net,
linux-wireless@vger.kernel.org
Subject: Re: [Make-wifi-fast] [PATCH] mac80211: Keep CoDel stats per txq, export them in debugfs.
Date: Thu, 11 Aug 2016 14:22:47 +0200 [thread overview]
Message-ID: <1470918167.12075.2.camel@sipsolutions.net> (raw)
In-Reply-To: <20160720145442.1098-1-toke@toke.dk> (sfid-20160720_165542_917420_468D4AF0)
> @@ -137,18 +137,20 @@ static int aqm_open(struct inode *inode, struct
> file *file)
> len += scnprintf(info->buf + len,
> info->size - len,
> "* vif\n"
> - "ifname addr ac backlog-bytes backlog-
> packets flows overlimit collisions tx-bytes tx-packets\n");
> + "ifname addr ac backlog-bytes backlog-
> packets flows drops marks overlimit collisions tx-bytes tx-
> packets\n");
It seems to me that you have to change the buffer length to take this
into account?
> list_for_each_entry_rcu(sdata, &local->interfaces, list) {
> txqi = to_txq_info(sdata->vif.txq);
> len += scnprintf(info->buf + len, info->size - len,
> - "%s %pM %u %u %u %u %u %u %u %u\n",
> + "%s %pM %u %u %u %u %u %u %u %u %u
> %u\n",
> sdata->name,
Why is it this way anyway? It'd seem nicer to move the content of this
into the per-netdev subdirectories, and then it becomes a lot simpler
code too (yes, at the expense of some userspace, but still)
> sdata->vif.addr,
This is also kinda pointless since it's easy to get elsewhere.
> txqi->txq.ac,
> txqi->tin.backlog_bytes,
> txqi->tin.backlog_packets,
> txqi->tin.flows,
> + txqi->cstats.drop_count,
> + txqi->cstats.ecn_mark,
> txqi->tin.overlimit,
> txqi->tin.collisions,
> txqi->tin.tx_bytes,
Do you really want to add these in the middle? Seems that if you add
them at the end, you at least have *some* way of keeping this working
with older versions?
johannes
next prev parent reply other threads:[~2016-08-11 12:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 14:54 Toke Høiland-Jørgensen
2016-08-11 12:22 ` Johannes Berg [this message]
2016-08-11 12:34 ` Toke Høiland-Jørgensen
2016-08-11 15:11 ` [Make-wifi-fast] [PATCH v2] mac80211: Re-structure aqm debugfs output and include CoDel drops Toke Høiland-Jørgensen
2016-09-12 9:27 ` Johannes Berg
2016-09-12 13:55 ` [Make-wifi-fast] [PATCH v3] mac80211: Re-structure aqm debugfs output and keep CoDel stats per txq Toke Høiland-Jørgensen
2016-09-13 7:17 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/make-wifi-fast.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470918167.12075.2.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=make-wifi-fast@lists.bufferbloat.net \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox