From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sipsolutions.net (s3.sipsolutions.net [5.9.151.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 966783B25D for ; Thu, 1 Sep 2016 05:07:30 -0400 (EDT) Received: by sipsolutions.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1bfNy5-0002pr-77; Thu, 01 Sep 2016 11:07:29 +0200 Message-ID: <1472720848.9608.1.camel@sipsolutions.net> From: Johannes Berg To: Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= Cc: make-wifi-fast@lists.bufferbloat.net, linux-wireless@vger.kernel.org Date: Thu, 01 Sep 2016 11:07:28 +0200 In-Reply-To: <8737lk816p.fsf@toke.dk> References: <20160824162015.29933-1-toke@toke.dk> <20160830131548.6014-1-toke@toke.dk> <1472677599.5470.13.camel@sipsolutions.net> <87inug81vo.fsf@toke.dk> <1472718860.4249.0.camel@sipsolutions.net> <8737lk816p.fsf@toke.dk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.4-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Make-wifi-fast] [PATCH v4] mac80211: Move reorder-sensitive TX handlers to after TXQ dequeue. X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Sep 2016 09:07:30 -0000 > > They have three possible values ... :) > > Ah, no, not the handlers themselves. Meant the invoke_tx_handlers() > function (or all three of them after my patch; hence the plural). To > avoid the "0 means true" confusion you alluded to :) > Ah. Actually, even I got confused and thought the return value *was* the same as the handler. I think it doesn't matter to be tricky, gcc is probably going to (have to) generate exactly the same code like when you explicitly put an if statement in there, it seems? johannes