From: Johannes Berg <johannes@sipsolutions.net>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>,
make-wifi-fast@lists.bufferbloat.net,
linux-wireless@vger.kernel.org
Subject: Re: [Make-wifi-fast] [PATCH v2] mac80211: Re-structure aqm debugfs output and include CoDel drops
Date: Mon, 12 Sep 2016 11:27:47 +0200 [thread overview]
Message-ID: <1473672467.4201.16.camel@sipsolutions.net> (raw)
In-Reply-To: <20160811151156.6485-1-toke@toke.dk> (sfid-20160811_171216_207117_5110F87B)
> --- a/net/mac80211/debugfs_sta.c
> +++ b/net/mac80211/debugfs_sta.c
> @@ -109,6 +109,48 @@ static ssize_t sta_last_seq_ctrl_read(struct
> file *file, char __user *userbuf,
> }
> STA_OPS(last_seq_ctrl);
>
> +#define AQM_TXQ_ENTRY_LEN 130
> +
> +static ssize_t sta_aqm_read(struct file *file, char __user *userbuf,
> + size_t count, loff_t *ppos)
> +{
> + struct sta_info *sta = file->private_data;
> + struct ieee80211_local *local = sta->local;
> + char buf[AQM_TXQ_ENTRY_LEN*(IEEE80211_NUM_TIDS+1)], *p =
> buf;
>
This is very large, I think you should dynamically allocate it.
johannes
next prev parent reply other threads:[~2016-09-12 9:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 14:54 [Make-wifi-fast] [PATCH] mac80211: Keep CoDel stats per txq, export them in debugfs Toke Høiland-Jørgensen
2016-08-11 12:22 ` Johannes Berg
2016-08-11 12:34 ` Toke Høiland-Jørgensen
2016-08-11 15:11 ` [Make-wifi-fast] [PATCH v2] mac80211: Re-structure aqm debugfs output and include CoDel drops Toke Høiland-Jørgensen
2016-09-12 9:27 ` Johannes Berg [this message]
2016-09-12 13:55 ` [Make-wifi-fast] [PATCH v3] mac80211: Re-structure aqm debugfs output and keep CoDel stats per txq Toke Høiland-Jørgensen
2016-09-13 7:17 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/make-wifi-fast.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473672467.4201.16.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=make-wifi-fast@lists.bufferbloat.net \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox