From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sipsolutions.net (s3.sipsolutions.net [5.9.151.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id DB9A43B25E for ; Mon, 12 Sep 2016 05:27:51 -0400 (EDT) Received: by sipsolutions.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1bjNWm-0006d4-EL; Mon, 12 Sep 2016 11:27:48 +0200 Message-ID: <1473672467.4201.16.camel@sipsolutions.net> From: Johannes Berg To: Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= , make-wifi-fast@lists.bufferbloat.net, linux-wireless@vger.kernel.org Date: Mon, 12 Sep 2016 11:27:47 +0200 In-Reply-To: <20160811151156.6485-1-toke@toke.dk> (sfid-20160811_171216_207117_5110F87B) References: <20160720145442.1098-1-toke@toke.dk> <20160811151156.6485-1-toke@toke.dk> (sfid-20160811_171216_207117_5110F87B) Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.4-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [Make-wifi-fast] [PATCH v2] mac80211: Re-structure aqm debugfs output and include CoDel drops X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2016 09:27:52 -0000 > --- a/net/mac80211/debugfs_sta.c > +++ b/net/mac80211/debugfs_sta.c > @@ -109,6 +109,48 @@ static ssize_t sta_last_seq_ctrl_read(struct > file *file, char __user *userbuf, >  } >  STA_OPS(last_seq_ctrl); >   > +#define AQM_TXQ_ENTRY_LEN 130 > + > +static ssize_t sta_aqm_read(struct file *file, char __user *userbuf, > + size_t count, loff_t *ppos) > +{ > + struct sta_info *sta = file->private_data; > + struct ieee80211_local *local = sta->local; > + char buf[AQM_TXQ_ENTRY_LEN*(IEEE80211_NUM_TIDS+1)], *p = > buf; > This is very large, I think you should dynamically allocate it. johannes