From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sipsolutions.net (s3.sipsolutions.net [5.9.151.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 40C6A3B260 for ; Fri, 30 Sep 2016 07:33:53 -0400 (EDT) Received: by sipsolutions.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1bpw4e-0000X6-5V; Fri, 30 Sep 2016 13:33:52 +0200 Message-ID: <1475235230.17481.43.camel@sipsolutions.net> From: Johannes Berg To: Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= , make-wifi-fast@lists.bufferbloat.net, linux-wireless@vger.kernel.org, netdev@vger.kernel.org Date: Fri, 30 Sep 2016 13:33:50 +0200 In-Reply-To: <20160923195911.4572-4-toke@toke.dk> (sfid-20160923_215935_754766_6EB4EDBF) References: <20160923195911.4572-1-toke@toke.dk> <20160923195911.4572-4-toke@toke.dk> (sfid-20160923_215935_754766_6EB4EDBF) Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.20.5-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [Make-wifi-fast] [PATCH 3/3] mac80211: Set lower memory limit for non-VHT devices X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Sep 2016 11:33:53 -0000 On Fri, 2016-09-23 at 21:59 +0200, Toke Høiland-Jørgensen wrote: > Small devices can run out of memory from queueing too many packets. > If VHT is not supported by the PHY, having more than 4 MBytes of > total queue in the TXQ intermediate queues is not needed, and so we > can safely limit the memory usage in these cases and avoid OOM. I kinda see the logic here - we really don't need to queue as much if we can't possibly transmit it out quickly - but it seems to me we should also throw in some kind of limit that's relative to the amount of memory you have on the system? I've applied these anyway though. I just don't like your assumption (b) much as the rationale for it. johannes