From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-x243.google.com (mail-pg0-x243.google.com [IPv6:2607:f8b0:400e:c05::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id E9B343B2A0 for ; Fri, 18 Nov 2016 09:13:55 -0500 (EST) Received: by mail-pg0-x243.google.com with SMTP id x23so20800024pgx.3 for ; Fri, 18 Nov 2016 06:13:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=nM3bQZRZYzADgbqVKXC227uHIFjF1QzcUMeaRfV/z4M=; b=ma63lYWp79lz+f/hGtxAimZO9XDTTHmjopB0u0dnwgRU7MLDk1jXBEx17V8te7j8AE mi8Ve4uj8BCvrfTvxovRJkv5bNHAC5VXqR0PmN69WTjmyXsomLQ4oGfpMVXq1Fa/BiHE FputIZXVY7+oZlP4i6EIHLyE9FMDuXN8TqveFS9DU8fmWJ8C7feQA0tJlPodcB7AHnkL y/meRfey8fQF5pWgyiPhpcIz8q4Ss8Ytq9dqsxtiAmpDEvluXfMVpm+75ZCyQXj47rm1 BM9dSkiThungLO+GApMMAueeyCV2XNypwl3yJtSY+xNkFU4Q6hlVnFnR7rmZsyCY5sRL Wn5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=nM3bQZRZYzADgbqVKXC227uHIFjF1QzcUMeaRfV/z4M=; b=gNy4Wd/6YqDsAimXTifcY+Y0NcYzG/4JMkAFivX09dJSOrI7nxxHkxBevIaZkjYbKO pu2lxE22yDyAnalC9WrRI0Bn1AKgSFaLoz4YhCX0cmx+NlxI99AFossMtaS8JkmKpvpp QKFTfttD73UtIS4J6y/kIOhTxRtBwPgQ5VbJ2nKc966nn0S6JA7wlnQ5UkzAD2+v4esF I1ovuaWHU61i6I0Atn0Mtj8wP1WhnIx6qt8d8VXPnrBkIZdys121XAnpzlGszpFQP57x 2rSld9L+C/BCqZJvHyvVtgBtjZUp6oa9LQSGsgwrz6r12DQmcm82xOtgqTeMghZW1ASo tgNQ== X-Gm-Message-State: ABUngveQyilhtccjbtlXwyXuyf6qd7sYaLfaCerhnelwayRxG6Pl+g/Vyoxd02TGvtmRLA== X-Received: by 10.99.171.65 with SMTP id k1mr19711806pgp.87.1479478435012; Fri, 18 Nov 2016 06:13:55 -0800 (PST) Received: from [172.19.242.88] ([172.19.242.88]) by smtp.googlemail.com with ESMTPSA id a22sm18563164pfg.7.2016.11.18.06.13.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Nov 2016 06:13:54 -0800 (PST) Message-ID: <1479478433.8455.284.camel@edumazet-glaptop3.roam.corp.google.com> From: Eric Dumazet To: Jesper Dangaard Brouer Cc: Dave Taht , make-wifi-fast@lists.bufferbloat.net Date: Fri, 18 Nov 2016 06:13:53 -0800 In-Reply-To: <20161118085524.62d6cfdd@redhat.com> References: <20161118085524.62d6cfdd@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Make-wifi-fast] a bit of profiling on the archer X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2016 14:13:56 -0000 On Fri, 2016-11-18 at 08:55 +0100, Jesper Dangaard Brouer wrote: > Be careful you don't fool yourself. In your output you have the > "children" mode on, so everything being called "under" net_rx_action is > summed up. It could be it goes all the way through to the wifi TX > parts and that is part of the sum. Even the memory allocations gets > summed into this 66% number. Yes, I really do not see how ag71xx would be to blame ;) Although.... looking at https://aachen.uni-dsl.de/svn/unidsl_firmware/backfire/trunk/backfire/target/linux/ar71xx/files/drivers/net/ag71xx/ag71xx_main.c I do see a bug : if (rx_done < limit) { if (status & RX_STATUS_PR) goto more; status = ag71xx_rr(ag, AG71XX_REG_TX_STATUS); if (status & TX_STATUS_PS) goto more; DBG("%s: disable polling mode, rx=%d, tx=%d,limit=%d\n", dev->name, rx_done, tx_done, limit); napi_complete(napi); Hint: napi_complete_done(napi, rx_done); /* enable interrupts */ spin_lock_irqsave(&ag->lock, flags); ag71xx_int_enable(ag, AG71XX_INT_POLL); spin_unlock_irqrestore(&ag->lock, flags); return rx_done; } more: DBG("%s: stay in polling mode, rx=%d, tx=%d, limit=%d\n", dev->name, rx_done, tx_done, limit); return rx_done; This last statement should be : "return limit;"