From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eric.dumazet@gmail.com>
Received: from mail-io0-x230.google.com (mail-io0-x230.google.com
 [IPv6:2607:f8b0:4001:c06::230])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id 451E13B2A4
 for <make-wifi-fast@lists.bufferbloat.net>;
 Thu,  6 Apr 2017 06:51:57 -0400 (EDT)
Received: by mail-io0-x230.google.com with SMTP id f84so26917844ioj.0
 for <make-wifi-fast@lists.bufferbloat.net>;
 Thu, 06 Apr 2017 03:51:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=message-id:subject:from:to:cc:date:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=q5thqNO57fWtu5rafxyJf/990lKgeK4hBFb2TbFcuas=;
 b=UcpWT2T62eAWkNlmnlv5tw+JqCFY5l9txPIwNj5N7RMnq4fjv5alLeeE7Gaw7HVHT7
 rJ/bctICCs21KgoCKUYXZJ5HThaAOy8+WNl7RaNbRLvzlPnxGLt0p3LfANxYYzYd/5F3
 6gi/fqNI0luNKXAyhoMLYV6wTTsHDaT6NXauTupSTubO1UO2afNll3GI9XzAo+QmesO4
 Zz/b7x+dflJt/jFNiCJ9EIiydmrvQR66n6InCjNgPU3yiMzgcDAgjRyHdjfq7QbA6YFe
 K4pGyUKDE4ZFIovbooOMQ6cIsTQC9TutgKZIITY6zJUjiwpJVRc5r1DIyJ2DDcPZltGX
 ugkA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=q5thqNO57fWtu5rafxyJf/990lKgeK4hBFb2TbFcuas=;
 b=CVliRgstvby4GFvxWbCGrzKaNYhEAJYaVlZ0oa+jU+J9uWguk1vQ57bAim5IX2D9Oy
 R0h1qsQ74uRilqfb/2NifUuQwxJDAxccKJb4JIi6/1Z5h6Wlc+6uaHaM8/59+4OSIbvb
 vYLacXGIj04g9W0a21tF1QE5Qm6BsBr/f5fI01Zn6XII+hytTpzGiS5iWMGwQ++VKbob
 DnvBnMvnrqFUPMkPcYjSmqcUx3aDVsbwbw7Wcaxr1j2lqSu23Ox48GgzOM2Ns4NJoLxt
 2/QlrZIvUwv+fFhe7eS1Vz8T8jI+i+FkM8HBExjBAuLK6b112Efbd0ytpPMgdU6Fl5RR
 oPng==
X-Gm-Message-State: AFeK/H0LWLftWcAPXz4pwoZBm0Fp3ixPCzt2+WurSkgqKxwgts9VNnIkyam2OzuhKnzl/Q==
X-Received: by 10.107.151.208 with SMTP id z199mr30951503iod.98.1491475916775; 
 Thu, 06 Apr 2017 03:51:56 -0700 (PDT)
Received: from [172.20.50.52] ([66.171.166.114])
 by smtp.googlemail.com with ESMTPSA id 89sm703945ioj.17.2017.04.06.03.51.55
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 06 Apr 2017 03:51:56 -0700 (PDT)
Message-ID: <1491475915.10124.75.camel@edumazet-glaptop3.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
To: Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= <toke@toke.dk>
Cc: make-wifi-fast@lists.bufferbloat.net, linux-wireless@vger.kernel.org
Date: Thu, 06 Apr 2017 03:51:55 -0700
In-Reply-To: <20170406093826.16626-1-toke@toke.dk>
References: <20170405161810.30671-1-toke@toke.dk>
 <20170406093826.16626-1-toke@toke.dk>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4-0ubuntu2 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [Make-wifi-fast] [PATCH v3] mac80211: Dynamically set CoDel
 parameters per station
X-BeenThere: make-wifi-fast@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: <make-wifi-fast.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/make-wifi-fast>,
 <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/make-wifi-fast>
List-Post: <mailto:make-wifi-fast@lists.bufferbloat.net>
List-Help: <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/make-wifi-fast>,
 <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Thu, 06 Apr 2017 10:51:57 -0000

On Thu, 2017-04-06 at 11:38 +0200, Toke Høiland-Jørgensen wrote:

> +
> +	if (thr && thr < STA_SLOW_THRESHOLD * sta->local->num_sta) {
> +		sta->cparams.target = MS2TIME(50);
> +		sta->cparams.interval = MS2TIME(300);
> +		sta->cparams.ecn = false;
> +	} else {
> +		sta->cparams.target = MS2TIME(20);
> +		sta->cparams.interval = MS2TIME(100);
> +		sta->cparams.ecn = true;
> +	}
> +}

Why ECN is flipped on/off like that ? ECN really should be an admin
choice.

Also, this change in parameters looks suspect to me, adding a bimodal
behavior. I would consult Kathleen and Van on this possibility.