From: Johannes Berg <johannes@sipsolutions.net>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>,
make-wifi-fast@lists.bufferbloat.net,
linux-wireless@vger.kernel.org
Subject: Re: [Make-wifi-fast] [RFC] mac80211: Add airtime fairness accounting
Date: Fri, 06 Oct 2017 16:07:12 +0200 [thread overview]
Message-ID: <1507298832.19300.20.camel@sipsolutions.net> (raw)
In-Reply-To: <20171006115232.28688-1-toke@toke.dk> (sfid-20171006_135301_379557_9AE74A5E)
On Fri, 2017-10-06 at 13:52 +0200, Toke Høiland-Jørgensen wrote:
> This adds accounting of each station's airtime usage to mac80211. On
> the RX side, airtime is calculated from the packet length and
> duration.
I think you should probably try to get something here from the driver?
Doing the calculations is really awkward, because you have to take into
account aggregation, etc.
However, I'm not even sure that you _want_ to use RX airtime at all? I
guess this is a fairly fundamental philosophical question, but there's
no way to feed back "you're sending too much" to a station, so if it
starts consuming a lot of airtime with (what we see as) RX, and we
throttle sending to it, then I'm not sure that will have much effect?
Maybe with TCP, but not really with anything else.
You also can't really know what AC this was on, and it doesn't make all
that much sense?
Then again, I'm not even sure yet why you care about the AC at all?
Should fairness really be something that's within an AC?
johannes
next prev parent reply other threads:[~2017-10-06 14:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 11:52 Toke Høiland-Jørgensen
2017-10-06 14:07 ` Johannes Berg [this message]
2017-10-06 14:18 ` Jonathan Morton
2017-10-06 17:12 ` Johannes Berg
2017-10-06 14:29 ` Toke Høiland-Jørgensen
2017-10-06 17:18 ` Johannes Berg
2017-10-06 22:40 ` David Lang
2017-10-07 11:22 ` Toke Høiland-Jørgensen
2017-10-09 7:15 ` Johannes Berg
2017-10-09 7:50 ` David Lang
2017-10-09 9:42 ` Toke Høiland-Jørgensen
2017-10-09 11:40 ` Johannes Berg
2017-10-09 12:38 ` Toke Høiland-Jørgensen
2017-10-09 18:50 ` Johannes Berg
2017-10-09 20:25 ` Toke Høiland-Jørgensen
2017-10-11 8:55 ` Johannes Berg
2017-10-11 13:50 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/make-wifi-fast.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507298832.19300.20.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=make-wifi-fast@lists.bufferbloat.net \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox