From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:72ef::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id A91C03B2A4 for ; Tue, 17 Oct 2017 06:00:45 -0400 (EDT) Received: by sipsolutions.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1e4Og0-0006xN-9Q; Tue, 17 Oct 2017 12:00:44 +0200 Message-ID: <1508234443.10607.72.camel@sipsolutions.net> From: Johannes Berg To: Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= , make-wifi-fast@lists.bufferbloat.net, linux-wireless@vger.kernel.org Date: Tue, 17 Oct 2017 12:00:43 +0200 In-Reply-To: <871sm2p6rt.fsf@toke.dk> References: <20171016160902.8970-1-toke@toke.dk> <20171016160902.8970-2-toke@toke.dk> <1508224046.10607.67.camel@sipsolutions.net> <871sm2p6rt.fsf@toke.dk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.0-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [Make-wifi-fast] [PATCH 2/2] mac80211: Add airtime accounting and scheduling to TXQs X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Oct 2017 10:00:45 -0000 On Tue, 2017-10-17 at 09:34 +0200, Toke Høiland-Jørgensen wrote: > Yeah, I did that initially. The reason I ended up squashing them is > that > this patch moved the per-station 'airtime' debugfs-entry that was > previously created by ath9k into mac80211. I assumed it would create > problems if both the driver and mac80211 tried to create the same > file; > not sure how to handle that if it's split into two patches? That might indeed be problematic, so perhaps just use a different name? Then again, if adding the entry fails in ath9k, nothing will happen since it doesn't even check the return value - so I think it doesn't actually matter. > > I'd prefer this were called "airtime" or such, > > Right. I picked rx_time for symmetry with the tx side; should I > rename that as well, then, or is asymmetry fine? Let's not change the tx side in this patch, but we can clean it up later I guess. johannes