From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:72ef::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id A7F753BA8E for ; Mon, 7 May 2018 15:13:06 -0400 (EDT) Received: by sipsolutions.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.91) (envelope-from ) id 1fFlZJ-0006wk-Cq; Mon, 07 May 2018 21:13:05 +0200 Message-ID: <1525720384.22388.2.camel@sipsolutions.net> From: Johannes Berg To: Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= , make-wifi-fast@lists.bufferbloat.net, linux-wireless@vger.kernel.org Date: Mon, 07 May 2018 21:13:04 +0200 In-Reply-To: <20180219170224.14816-2-toke@toke.dk> (sfid-20180219_180300_682375_800CE1A2) References: <20180219170224.14816-1-toke@toke.dk> <20180219170224.14816-2-toke@toke.dk> (sfid-20180219_180300_682375_800CE1A2) Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.6 (3.26.6-1.fc27) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [Make-wifi-fast] [PATCH 1/3] cfg80211: Expose TXQ stats and parameters to userspace X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 May 2018 19:13:06 -0000 On Mon, 2018-02-19 at 18:02 +0100, Toke Høiland-Jørgensen wrote: > This adds support for exporting the mac80211 TXQ stats via nl80211 by > way of a nested TXQ stats attribute, as well as for configuring the > quantum and limits that were previously only changeable through debugfs. So I finally (sorry) decided to apply this, but I get a few issues with it (aside from trivial rebase issues). If you're not able to fix them now let me know and I can: 1) Lots of places put the sinfo on the stack, but it's now way bigger, so we get warnings like net/mac80211/ethtool.c: In function ‘ieee80211_get_stats’: net/mac80211/ethtool.c:204:1: warning: the frame size of 1752 bytes is larger than 1024 bytes [-Wframe-larger-than=] net/mac80211/ethtool.c:74 ieee80211_get_stats() warn: 'sinfo' puts 1672 bytes on stack I guess we need to pull those out to dynamic allocations. net/mac80211/cfg.c:3762:12: warning: context imbalance in 'ieee80211_get_txq_stats' - different lock contexts for basic block net/mac80211/tx.c: In function ‘ieee80211_txq_set_params’: net/mac80211/tx.c:1478:1: warning: control reaches end of non-void function [-Wreturn-type] also show up. johannes