From: Johannes Berg <johannes@sipsolutions.net>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>,
make-wifi-fast@lists.bufferbloat.net,
linux-wireless@vger.kernel.org
Subject: Re: [Make-wifi-fast] [PATCH 2/3] iw: Print TXQ statistics for stations and interfaces
Date: Mon, 07 May 2018 23:21:30 +0200 [thread overview]
Message-ID: <1525728090.6222.1.camel@sipsolutions.net> (raw)
In-Reply-To: <20180219170224.14816-3-toke@toke.dk> (sfid-20180219_180319_201142_47E9DB27)
On Mon, 2018-02-19 at 18:02 +0100, Toke Høiland-Jørgensen wrote:
>
> + if (header && tid >= 0)
> + pos += snprintf(buf, buflen, "\n\t\tTID\tqsz-byt\t"
> + "qsz-pkt\tflows\tdrops\tmarks\toverlmt\t"
> + "hashcol\ttx-bytes\ttx-packets");
> + else if (header)
> + pos += snprintf(buf, buflen, "\n\t\tqsz-byt\t"
> + "qsz-pkt\tflows\tdrops\tmarks\toverlmt\t"
> + "hashcol\ttx-bytes\ttx-packets");
> +
> + if (tid >= 0)
> + pos += snprintf(pos, buflen - (pos - buf), "\n\t\t%d", tid);
> + else
> + pos += snprintf(pos, buflen - (pos - buf), "\n\t");
> +
> + txqinfo = txqstats_info[NL80211_TXQ_STATS_BACKLOG_BYTES];
> + if (txqinfo)
> + pos += snprintf(pos, buflen - (pos - buf), "\t%u",
> + nla_get_u32(txqinfo));
since the header is fixed, shouldn't all of these get an else branch
that just prints a tab or so?
johannes
next prev parent reply other threads:[~2018-05-07 21:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 17:02 [Make-wifi-fast] [PATCH 0/3] Export TXQ parameters and statistics via nl80211 Toke Høiland-Jørgensen
2018-02-19 17:02 ` [Make-wifi-fast] [PATCH 1/3] cfg80211: Expose TXQ stats and parameters to userspace Toke Høiland-Jørgensen
2018-05-07 19:13 ` Johannes Berg
2018-05-07 21:19 ` Toke Høiland-Jørgensen
2018-05-07 21:20 ` Johannes Berg
2018-05-08 10:18 ` Toke Høiland-Jørgensen
2018-05-08 10:18 ` Johannes Berg
2018-05-08 10:19 ` Johannes Berg
2018-05-08 10:23 ` Toke Høiland-Jørgensen
2018-05-08 10:21 ` Johannes Berg
2018-02-19 17:02 ` [Make-wifi-fast] [PATCH 2/3] iw: Print TXQ statistics for stations and interfaces Toke Høiland-Jørgensen
2018-05-07 21:21 ` Johannes Berg [this message]
2018-05-07 21:30 ` Toke Høiland-Jørgensen
2018-02-19 17:02 ` [Make-wifi-fast] [PATCH 3/3] iw: Add getting and setting of TXQ params for phy Toke Høiland-Jørgensen
2018-02-21 8:56 ` [Make-wifi-fast] [PATCH 0/3] Export TXQ parameters and statistics via nl80211 Arend van Spriel
2018-02-21 11:00 ` Toke Høiland-Jørgensen
2018-02-21 19:53 ` Arend van Spriel
2018-02-22 10:11 ` Toke Høiland-Jørgensen
2018-02-22 10:18 ` [Make-wifi-fast] [PATCH v2] iw: Print TXQ statistics for stations and interfaces Toke Høiland-Jørgensen
2018-02-22 12:10 ` Pete Heist
2018-02-22 12:32 ` Toke Høiland-Jørgensen
2018-04-19 9:20 ` [Make-wifi-fast] [PATCH 0/3] Export TXQ parameters and statistics via nl80211 Toke Høiland-Jørgensen
2018-04-19 9:52 ` Johannes Berg
2018-04-19 10:30 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/make-wifi-fast.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1525728090.6222.1.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=make-wifi-fast@lists.bufferbloat.net \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox