From: Johannes Berg <johannes@sipsolutions.net>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>,
make-wifi-fast@lists.bufferbloat.net,
linux-wireless@vger.kernel.org
Subject: Re: [Make-wifi-fast] [PATCH 1/3] cfg80211: Expose TXQ stats and parameters to userspace
Date: Tue, 08 May 2018 12:19:06 +0200 [thread overview]
Message-ID: <1525774746.14830.4.camel@sipsolutions.net> (raw)
In-Reply-To: <87in7y5u3h.fsf@toke.dk>
On Tue, 2018-05-08 at 12:18 +0200, Toke Høiland-Jørgensen wrote:
> Johannes Berg <johannes@sipsolutions.net> writes:
>
> > net/mac80211/cfg.c:3762:12: warning: context imbalance in
> > 'ieee80211_get_txq_stats' - different lock contexts for basic block
>
> Found and fixed all the other warnings, but I'm not seeing this one. And
> I don't really see what is wrong with the locking in that function? What
> am I missing?
Oh and what's wrong is that you "return 1" from the function with a lock
held in one place, IIRC.
johannes
next prev parent reply other threads:[~2018-05-08 10:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 17:02 [Make-wifi-fast] [PATCH 0/3] Export TXQ parameters and statistics via nl80211 Toke Høiland-Jørgensen
2018-02-19 17:02 ` [Make-wifi-fast] [PATCH 1/3] cfg80211: Expose TXQ stats and parameters to userspace Toke Høiland-Jørgensen
2018-05-07 19:13 ` Johannes Berg
2018-05-07 21:19 ` Toke Høiland-Jørgensen
2018-05-07 21:20 ` Johannes Berg
2018-05-08 10:18 ` Toke Høiland-Jørgensen
2018-05-08 10:18 ` Johannes Berg
2018-05-08 10:19 ` Johannes Berg [this message]
2018-05-08 10:23 ` Toke Høiland-Jørgensen
2018-05-08 10:21 ` Johannes Berg
2018-02-19 17:02 ` [Make-wifi-fast] [PATCH 2/3] iw: Print TXQ statistics for stations and interfaces Toke Høiland-Jørgensen
2018-05-07 21:21 ` Johannes Berg
2018-05-07 21:30 ` Toke Høiland-Jørgensen
2018-02-19 17:02 ` [Make-wifi-fast] [PATCH 3/3] iw: Add getting and setting of TXQ params for phy Toke Høiland-Jørgensen
2018-02-21 8:56 ` [Make-wifi-fast] [PATCH 0/3] Export TXQ parameters and statistics via nl80211 Arend van Spriel
2018-02-21 11:00 ` Toke Høiland-Jørgensen
2018-02-21 19:53 ` Arend van Spriel
2018-02-22 10:11 ` Toke Høiland-Jørgensen
2018-02-22 10:18 ` [Make-wifi-fast] [PATCH v2] iw: Print TXQ statistics for stations and interfaces Toke Høiland-Jørgensen
2018-02-22 12:10 ` Pete Heist
2018-02-22 12:32 ` Toke Høiland-Jørgensen
2018-04-19 9:20 ` [Make-wifi-fast] [PATCH 0/3] Export TXQ parameters and statistics via nl80211 Toke Høiland-Jørgensen
2018-04-19 9:52 ` Johannes Berg
2018-04-19 10:30 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/make-wifi-fast.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1525774746.14830.4.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=make-wifi-fast@lists.bufferbloat.net \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox