From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:72ef::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 5CDC63BA8E for ; Tue, 8 May 2018 06:19:08 -0400 (EDT) Received: by sipsolutions.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.91) (envelope-from ) id 1fFzi7-0000Us-DX; Tue, 08 May 2018 12:19:07 +0200 Message-ID: <1525774746.14830.4.camel@sipsolutions.net> From: Johannes Berg To: Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= , make-wifi-fast@lists.bufferbloat.net, linux-wireless@vger.kernel.org Date: Tue, 08 May 2018 12:19:06 +0200 In-Reply-To: <87in7y5u3h.fsf@toke.dk> References: <20180219170224.14816-1-toke@toke.dk> <20180219170224.14816-2-toke@toke.dk> <1525720384.22388.2.camel@sipsolutions.net> <87in7y5u3h.fsf@toke.dk> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.6 (3.26.6-1.fc27) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [Make-wifi-fast] [PATCH 1/3] cfg80211: Expose TXQ stats and parameters to userspace X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 May 2018 10:19:08 -0000 On Tue, 2018-05-08 at 12:18 +0200, Toke Høiland-Jørgensen wrote: > Johannes Berg writes: > > > net/mac80211/cfg.c:3762:12: warning: context imbalance in > > 'ieee80211_get_txq_stats' - different lock contexts for basic block > > Found and fixed all the other warnings, but I'm not seeing this one. And > I don't really see what is wrong with the locking in that function? What > am I missing? Oh and what's wrong is that you "return 1" from the function with a lock held in one place, IIRC. johannes