From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <johannes@sipsolutions.net>
Received: from sipsolutions.net (s3.sipsolutions.net
 [IPv6:2a01:4f8:191:72ef::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id D69523BA8E
 for <make-wifi-fast@lists.bufferbloat.net>;
 Tue,  8 May 2018 06:21:03 -0400 (EDT)
Received: by sipsolutions.net with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.91)
 (envelope-from <johannes@sipsolutions.net>)
 id 1fFzjy-0000iA-Ud; Tue, 08 May 2018 12:21:03 +0200
Message-ID: <1525774861.14830.5.camel@sipsolutions.net>
From: Johannes Berg <johannes@sipsolutions.net>
To: Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= <toke@toke.dk>, 
 make-wifi-fast@lists.bufferbloat.net, linux-wireless@vger.kernel.org
Date: Tue, 08 May 2018 12:21:01 +0200
In-Reply-To: <20180219170224.14816-2-toke@toke.dk>
 (sfid-20180219_180300_682375_800CE1A2)
References: <20180219170224.14816-1-toke@toke.dk>
 <20180219170224.14816-2-toke@toke.dk>
 (sfid-20180219_180300_682375_800CE1A2)
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.26.6 (3.26.6-1.fc27) 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [Make-wifi-fast] [PATCH 1/3] cfg80211: Expose TXQ stats and
 parameters to userspace
X-BeenThere: make-wifi-fast@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: <make-wifi-fast.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/make-wifi-fast>,
 <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/make-wifi-fast>
List-Post: <mailto:make-wifi-fast@lists.bufferbloat.net>
List-Help: <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/make-wifi-fast>,
 <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Tue, 08 May 2018 10:21:04 -0000

On Mon, 2018-02-19 at 18:02 +0100, Toke Høiland-Jørgensen wrote:
> +static int ieee80211_get_txq_stats(struct wiphy *wiphy,
> +                                  struct wireless_dev *wdev,
> +                                  struct cfg80211_txq_stats *txqstats)
> +{
> +       struct ieee80211_local *local = wiphy_priv(wiphy);
> +       struct ieee80211_sub_if_data *sdata;
> +
> +       if (!local->ops->wake_tx_queue)
> +               return 1;
> +
> +       spin_lock_bh(&local->fq.lock);
> +       rcu_read_lock();
> +
> +       if (wdev) {
> +               sdata = IEEE80211_WDEV_TO_SUB_IF(wdev);
> +               if (!sdata->vif.txq)
> +                       return 1;

here.

btw, it'd be nice to split it into cfg80211 and mac80211 separate
patches.

johannes