From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 88F823BA8E for ; Wed, 29 Aug 2018 03:44:27 -0400 (EDT) Received: by sipsolutions.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.91) (envelope-from ) id 1fuv9N-0002vL-OS; Wed, 29 Aug 2018 09:44:25 +0200 Message-ID: <1535528658.5215.19.camel@sipsolutions.net> From: Johannes Berg To: Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= , linux-wireless@vger.kernel.org Cc: make-wifi-fast@lists.bufferbloat.net, Felix Fietkau Date: Wed, 29 Aug 2018 09:44:18 +0200 In-Reply-To: <153115422499.7447.2570671473822724496.stgit@alrua-x1> (sfid-20180709_183717_542396_91AD1C0D) References: <153115421866.7447.6363834356268564403.stgit@alrua-x1> <153115422499.7447.2570671473822724496.stgit@alrua-x1> (sfid-20180709_183717_542396_91AD1C0D) Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.6 (3.26.6-1.fc27) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [Make-wifi-fast] [RFC v2 2/4] mac80211: Add airtime accounting and scheduling to TXQs X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2018 07:44:27 -0000 On Mon, 2018-07-09 at 18:37 +0200, Toke Høiland-Jørgensen wrote: > > @@ -427,6 +428,8 @@ struct sta_info *sta_info_alloc(struct ieee80211_sub_if_data *sdata, > sta->cparams.interval = MS2TIME(100); > sta->cparams.ecn = true; > > + sta->airtime.weight = 1; Perhaps it might be useful to start with a higher default (even something like 1<<8) as that would allow adjusting up/down single stations, without having to adjust all stations and listening to new additions to adjust them quickly etc? Theoretically this doesn't really matter, but from a practical POV it may be easier to leave them all at the default and just adjust the ones that need adjustment for some reason. > ieee80211_sta_register_airtime Do we really need this? We already have at least TX status with airtime, for ieee80211_sta_tx_notify() and friends, and the station pointer in that context, so couldn't we piggy-back on this? At least WMM-AC already requires the driver to provide this. johannes