From: kbuild test robot <lkp@intel.com>
To: Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
Cc: kbuild-all@01.org, linux-wireless@vger.kernel.org,
ath10k@lists.infradead.org, make-wifi-fast@lists.bufferbloat.net,
Kan Yan <kyan@google.com>,
Rajkumar Manoharan <rmanohar@codeaurora.org>
Subject: Re: [Make-wifi-fast] [PATCH v2 6/6] ath10k: reporting estimated tx airtime for fairness
Date: Tue, 13 Nov 2018 10:53:14 +0800 [thread overview]
Message-ID: <201811131022.tQgfDvyL%fengguang.wu@intel.com> (raw)
In-Reply-To: <1541805421-27309-7-git-send-email-rmanohar@qti.qualcomm.com>
[-- Attachment #1: Type: text/plain, Size: 2863 bytes --]
Hi Kan,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on mac80211/master]
[also build test WARNING on v4.20-rc1]
[cannot apply to next-20181112]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Rajkumar-Manoharan/Move-TXQ-scheduling-and-airtime-fairness-into-mac80211/20181111-072032
base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211.git master
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
include/linux/slab.h:332:43: warning: dubious: x & !y
include/linux/slab.h:332:43: warning: dubious: x & !y
>> net/mac80211/tx.c:3751:6: warning: context imbalance in 'ieee80211_txq_schedule_start' - wrong count at exit
>> net/mac80211/tx.c:3760:6: warning: context imbalance in 'ieee80211_txq_schedule_end' - unexpected unlock
vim +/ieee80211_txq_schedule_start +3751 net/mac80211/tx.c
30e0c998 Toke Høiland-Jørgensen 2018-11-09 3750
713c0ba8 Toke Høiland-Jørgensen 2018-11-09 @3751 void ieee80211_txq_schedule_start(struct ieee80211_hw *hw, u8 ac)
713c0ba8 Toke Høiland-Jørgensen 2018-11-09 3752 {
713c0ba8 Toke Høiland-Jørgensen 2018-11-09 3753 struct ieee80211_local *local = hw_to_local(hw);
713c0ba8 Toke Høiland-Jørgensen 2018-11-09 3754
713c0ba8 Toke Høiland-Jørgensen 2018-11-09 3755 spin_lock_bh(&local->active_txq_lock[ac]);
713c0ba8 Toke Høiland-Jørgensen 2018-11-09 3756 local->schedule_round[ac]++;
713c0ba8 Toke Høiland-Jørgensen 2018-11-09 3757 }
713c0ba8 Toke Høiland-Jørgensen 2018-11-09 3758 EXPORT_SYMBOL(ieee80211_txq_schedule_start);
713c0ba8 Toke Høiland-Jørgensen 2018-11-09 3759
713c0ba8 Toke Høiland-Jørgensen 2018-11-09 @3760 void ieee80211_txq_schedule_end(struct ieee80211_hw *hw, u8 ac)
713c0ba8 Toke Høiland-Jørgensen 2018-11-09 3761 {
713c0ba8 Toke Høiland-Jørgensen 2018-11-09 3762 struct ieee80211_local *local = hw_to_local(hw);
713c0ba8 Toke Høiland-Jørgensen 2018-11-09 3763
713c0ba8 Toke Høiland-Jørgensen 2018-11-09 3764 spin_unlock_bh(&local->active_txq_lock[ac]);
713c0ba8 Toke Høiland-Jørgensen 2018-11-09 3765 }
713c0ba8 Toke Høiland-Jørgensen 2018-11-09 3766 EXPORT_SYMBOL(ieee80211_txq_schedule_end);
713c0ba8 Toke Høiland-Jørgensen 2018-11-09 3767
:::::: The code at line 3751 was first introduced by commit
:::::: 713c0ba81183867042981a05259f4910183c5c4f mac80211: Add TXQ scheduling API
:::::: TO: Toke Høiland-Jørgensen <toke@toke.dk>
:::::: CC: 0day robot <lkp@intel.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 66525 bytes --]
prev parent reply other threads:[~2018-11-13 3:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 23:16 [Make-wifi-fast] [PATCH v2 0/6] Move TXQ scheduling and airtime fairness into mac80211 Rajkumar Manoharan
2018-11-09 23:16 ` [Make-wifi-fast] [PATCH v2 1/6] mac80211: Add TXQ scheduling API Rajkumar Manoharan
2018-11-09 23:16 ` [Make-wifi-fast] [PATCH v2 2/6] cfg80211: Add airtime statistics and settings Rajkumar Manoharan
2018-11-09 23:16 ` [Make-wifi-fast] [PATCH v2 3/6] mac80211: Add airtime accounting and scheduling to TXQs Rajkumar Manoharan
2018-11-10 23:57 ` kbuild test robot
2018-11-12 23:20 ` kbuild test robot
2018-11-09 23:16 ` [Make-wifi-fast] [PATCH v2 4/6] ath9k: Switch to mac80211 TXQ scheduling and airtime APIs Rajkumar Manoharan
2018-11-09 23:17 ` [Make-wifi-fast] [PATCH v2 5/6] ath10k: migrate to mac80211 txq scheduling Rajkumar Manoharan
2018-11-09 23:17 ` [Make-wifi-fast] [PATCH v2 6/6] ath10k: reporting estimated tx airtime for fairness Rajkumar Manoharan
2018-11-13 2:53 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/make-wifi-fast.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201811131022.tQgfDvyL%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=ath10k@lists.infradead.org \
--cc=kbuild-all@01.org \
--cc=kyan@google.com \
--cc=linux-wireless@vger.kernel.org \
--cc=make-wifi-fast@lists.bufferbloat.net \
--cc=rmanohar@codeaurora.org \
--cc=rmanohar@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox