From: Eric Dumazet <eric.dumazet@gmail.com>
To: Simon Barber <simon@superduper.net>, Dave Taht <dave.taht@gmail.com>
Cc: Make-Wifi-fast <make-wifi-fast@lists.bufferbloat.net>,
Johannes Berg <johannes@sipsolutions.net>,
linux-wireless <linux-wireless@vger.kernel.org>,
Neal Cardwell <ncardwell@google.com>,
Netdev <netdev@vger.kernel.org>
Subject: Re: [Make-wifi-fast] debugging TCP stalls on high-speed wifi
Date: Thu, 12 Dec 2019 17:46:55 -0800 [thread overview]
Message-ID: <34a05f62-8dd0-9ea0-2192-1da5bfe6d843@gmail.com> (raw)
In-Reply-To: <22B5F072-630A-44BE-A0E5-BF814A6CB9B0@superduper.net>
On 12/12/19 4:59 PM, Simon Barber wrote:
> I’m currently adding ACK thinning to Linux’s GRO code. Quite a simple addition given the way that code works.
>
> Simon
>
>
Please don't.
1) It will not help since many NIC do not use GRO.
2) This does not help if you receive one ACK per NIC interrupt, which is quite common.
3) This breaks GRO transparency.
4) TCP can implement this in a more effective/controlled way,
since the peer know a lot more flow characteristics.
Middle-box should not try to make TCP better, they usually break things.
next prev parent reply other threads:[~2019-12-13 1:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <14cedbb9300f887fecc399ebcdb70c153955f876.camel@sipsolutions.net>
[not found] ` <CADVnQym_CNktZ917q0-9dVY9dhtiJVRRotGTrPNdZUpkjd3vyw@mail.gmail.com>
[not found] ` <f4670ce0f4399fe82e7168fb9c491d8eb718e8d8.camel@sipsolutions.net>
[not found] ` <99748db5-7898-534b-d407-ed819f07f939@gmail.com>
[not found] ` <ff6b35ad589d7cf0710cb9fca4c799538da2e653.camel@sipsolutions.net>
2019-12-12 23:42 ` Dave Taht
2019-12-13 0:59 ` Simon Barber
2019-12-13 1:46 ` Eric Dumazet [this message]
2019-12-13 1:57 ` Simon Barber
2019-12-13 4:42 ` Dave Taht
2019-12-13 8:08 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/make-wifi-fast.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34a05f62-8dd0-9ea0-2192-1da5bfe6d843@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=dave.taht@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=make-wifi-fast@lists.bufferbloat.net \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=simon@superduper.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox