From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 480F43B29D for ; Fri, 22 Nov 2019 07:12:40 -0500 (EST) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.92.3) (envelope-from ) id 1iY7nj-0002lN-42; Fri, 22 Nov 2019 13:12:39 +0100 Message-ID: <3e7bea0cc643714ec90978a7999022544a39b118.camel@sipsolutions.net> From: Johannes Berg To: Kan Yan Cc: linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net, toke@redhat.com, nbd@nbd.name, yiboz@codeaurora.org, john@phrozen.org, lorenzo@kernel.org, rmanohar@codeaurora.org, kevinhayes@google.com Date: Fri, 22 Nov 2019 13:12:37 +0100 In-Reply-To: <20191119060610.76681-3-kyan@google.com> (sfid-20191119_070625_522904_ADC19544) References: <20191119060610.76681-1-kyan@google.com> <20191119060610.76681-3-kyan@google.com> (sfid-20191119_070625_522904_ADC19544) Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [Make-wifi-fast] [PATCH v11 2/4] mac80211: Import airtime calculation code from mt76 X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Nov 2019 12:12:40 -0000 On Mon, 2019-11-18 at 22:06 -0800, Kan Yan wrote: > From: Toke Høiland-Jørgensen > > Felix recently added code to calculate airtime of packets to the mt76 > driver. Import this into mac80211 so we can use it for airtime queue limit > calculations. > > The airtime.c file is copied verbatim from the mt76 driver, and adjusted to > be usable in mac80211. This involves: > > - Switching to mac80211 data structures. > - Adding support for 160 MHz channels and HE mode. > - Moving the symbol and duration calculations around a bit to avoid > rounding with the higher rates and longer symbol times used for HE rates. :) I'll apply this, I guess, but I do wonder to what extent it overlaps with cfg80211_calculate_bitrate()? johannes