From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 0D1073CB37 for ; Fri, 28 Sep 2018 06:35:18 -0400 (EDT) Received: by mail-lj1-x241.google.com with SMTP id 5-v6so5347943lju.6 for ; Fri, 28 Sep 2018 03:35:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=8hy3niZF/l97v4Ns2Gf1rhpp+Ch/DHelIBWRZC2DFAw=; b=YWwxcBfwGEfqyNt1oqTfN6lIU7YYQh/DYRJWVyuuUzNcD4CL8dqYSveO59j60kv21T 6iqQyM3bFYtL5TbGUgi46Wdp5J6NVYiY32klkzTVsLa8Rmnp1nnpJ9itlZ5IUtErWILx eetbma+95Xvy8QoC9yRf4XXZZnSaccfT3PrIHUkkYjg2537mS2huRmKa0HZLZvAZPq0T uizqJTSKa4WQgNGIc+GZDGJpEDAvX6j+ojpquidMDH5KbIfa1bfBNZgqfT+oNjSUsdY8 br9ISe8tOCmiEuKKpenzLQA0tjGwSNl+eXiEXQCEJed9G0HLMamykmQwFD6ydC3OerVG tNpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=8hy3niZF/l97v4Ns2Gf1rhpp+Ch/DHelIBWRZC2DFAw=; b=B6pwSqui0onMz3U7tDaJaiH/co4SmIGRQplDEvr+XHb/OJ4THHjrKkMAJnqY2+oJeh ElO3+lSwh9YjPpAxVnlkEN8RRwuE3uTb2t1/MOB+gsezYT8tDb6PyNtGUf5ZBZ/6DaZp yeNGIvBrNkQuC2BCeuU6aFMvaxVcWpUNlM4akoHf+yPfzCGLl4+lPohUZa7EhyTUZb0X /+wNrkvzf18QZTCWhCI7+b7pKlgElV6CKtQDcFvObZV5toY176Z4ZGaleka7SRrHJG9a ztfumcp5x6TV72PSqV0VXjPphpREq69P1IU2Hi8VfyzkC1mdqEhZys2NtZgWoJbfEoGU J5DA== X-Gm-Message-State: ABuFfohQhL2xXX0UvkjKuwQKC/lOlIW0NU7b8DFrg455TYbO5Sl3JR+H /qY5PvyXZk11rmgIyyXUmyM= X-Google-Smtp-Source: ACcGV60XqV7f1PtZ3OKYI9tSpUW8TzH+4Esyn+EP7l4kNhLLsN+ex6B968LAc/CSNOI9vdf0YvvgbQ== X-Received: by 2002:a2e:9e99:: with SMTP id f25-v6mr2117657ljk.142.1538130916816; Fri, 28 Sep 2018 03:35:16 -0700 (PDT) Received: from jonathartonsmbp.lan (83-245-238-10-nat-p.elisa-mobile.fi. [83.245.238.10]) by smtp.gmail.com with ESMTPSA id g5-v6sm949800ljg.54.2018.09.28.03.35.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Sep 2018 03:35:16 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) From: Jonathan Morton In-Reply-To: <5d961a5f61de45b85b1b037bcef9270d@codeaurora.org> Date: Fri, 28 Sep 2018 13:35:14 +0300 Cc: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , Kan Yan , make-wifi-fast@lists.bufferbloat.net, linux-wireless-owner@vger.kernel.org, linux-wireless@vger.kernel.org, Felix Fietkau Content-Transfer-Encoding: quoted-printable Message-Id: <44B09168-C08F-4C85-8D74-D576CCC79880@gmail.com> References: <153711966150.9231.13481453399723518107.stgit@alrua-x1> <153711973134.9231.18038849900399644494.stgit@alrua-x1.karlstad.toke.dk> <826b6251746ee4d280d532f4ecdc5aa3@codeaurora.org> <87pnx0haud.fsf@toke.dk> <8f7145bf5abe50194bced025a5e739b9@codeaurora.org> <863bc54fbf04441d38dd53f523300a7e@codeaurora.org> <93015743-5D16-4D79-948F-E2F46CF2450A@toke.dk> <7ba8513b0ec5a7c35b396c7739fc2d7d@codeaurora.org> <87zhw2eyfo.fsf@toke.dk> <5d961a5f61de45b85b1b037bcef9270d@codeaurora.org> To: Rajkumar Manoharan X-Mailer: Apple Mail (2.3445.9.1) Subject: Re: [Make-wifi-fast] [PATCH RFC v4 3/4] mac80211: Add airtime accounting and scheduling to TXQs X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Sep 2018 10:35:18 -0000 > On 28 Sep, 2018, at 1:19 pm, Rajkumar Manoharan = wrote: >=20 >> This is going to break fairness; we only want to increase deficits = when >> all stations' deficits are negative. Hence the two loops. Did you see >> any problems with those specifically? >=20 > No. I didn't see any issue but the loop won't exit until one txq = becomes positive. > Till then the lock won't be released. Hence I converged into single = iteration. The problem is that the fairness behaviour is changed when there are = already positive txqs, but the first one happens to not be positive. = That's why there were two loops. - Jonathan Morton