From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 2850C3CB35 for ; Wed, 19 Sep 2018 12:55:01 -0400 (EDT) Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 5BAF960BEE; Wed, 19 Sep 2018 16:55:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1537376100; bh=uBWVvEy2aY6m3XcleXV3Kf4cegw/Kb/dseeN6Wry3f8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gSM89QWx6EercIiqVvf4asBm1laY5KInMOQeGgRw86+LJcSzs539n9YyFEvAd/tgQ NJYSTmZtcHP+r+auJKKM9M9aljCYB4f3Oy2pYpPo07VAhw0TIhBhn6qCAABOmZOFfk gSHj2aqTBylPN4NhG6uf2Fr5J3zGfscLbMEUbXqs= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id B19F760364; Wed, 19 Sep 2018 16:54:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1537376099; bh=uBWVvEy2aY6m3XcleXV3Kf4cegw/Kb/dseeN6Wry3f8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Ej7Yd9/G0uGrZrpU5wCXr3hzp38E0cb5a/Cup88Pe9VQ2Wve/heBaSPcNiaqZsV/A Y+mtIU9xwfCN3IrBNwcIGL8eZfAdX9P/tx9TCJjsT53ujSUk5uIK4ZsHMtzU3S+8hP wiRFTvII5jdxUYxL3thpIpWUCpmtRxYfhS9G6Cos= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 19 Sep 2018 09:54:59 -0700 From: Rajkumar Manoharan To: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Cc: Kalle Valo , linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net, Felix Fietkau , Kan Yan , linux-wireless-owner@vger.kernel.org In-Reply-To: <8736u5k0cu.fsf@toke.dk> References: <153711966150.9231.13481453399723518107.stgit@alrua-x1> <153711973109.9231.7094211814263758096.stgit@alrua-x1.karlstad.toke.dk> <13400b5f9bdb5e36c6afabd071cc7b0d@codeaurora.org> <87o9cvksiv.fsf@toke.dk> <87efdq8rn0.fsf@toke.dk> <5e2612cbd4ea9f560a63149c599f8587@codeaurora.org> <87y3bxkg5p.fsf@toke.dk> <878t3xsg3h.fsf@purkki.adurom.net> <8736u5k0cu.fsf@toke.dk> Message-ID: <4b0b297a0ecf2f1e7278c23ab1ebe984@codeaurora.org> X-Sender: rmanohar@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Subject: Re: [Make-wifi-fast] [PATCH RFC v4 1/4] mac80211: Add TXQ scheduling API X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Sep 2018 16:55:01 -0000 On 2018-09-19 07:50, Toke Høiland-Jørgensen wrote: > Kalle Valo writes: > >> Toke Høiland-Jørgensen writes: >> >>>> Unfortunately ath10k is not reporting last_tx_rate in tx_status(). >>>> So >>>> I also applied this "ath10k: report tx rate using >>>> ieee80211_tx_status" >>>> change. >>> >>> Yeah, that and the patch that computes the last used rate will >>> probably >>> be necessary; but they can be pretty much applied as-is, right? >> >> Unfortunately not. I think the plan is now to follow Johannes' >> proposal: >> >> "I'd recommend against doing this and disentangling the necessary >> code in mac80211, e.g. with ieee80211_tx_status_ext() or adding >> similar APIs." >> >> https://patchwork.kernel.org/patch/10353959/ > > Ahh, right... *that* patch :) > > Was thinking on this one with the "as-is" comment: > > https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/588189 > It is useful only when the driver calls tx_status_noskb(). It was recommended not to call tx_status() and tx_status_noskb() APIs from same driver. Hence Anil was trying to piggyback tx rate report by tx_status itself. https://chromium.googlesource.com/chromiumos/third_party/kernel/+/1e034d84bd444fd29b7f902c5e033a8c737a58b2%5E%21/ https://chromium.googlesource.com/chromiumos/third_party/kernel/+/2a8da427fc9dfb527516e7ac395b1e6af73bff84%5E%21/ -Rajkumar