From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 49D0F3B29E for ; Fri, 25 Jan 2019 08:25:57 -0500 (EST) Received: by sipsolutions.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92-RC4) (envelope-from ) id 1gn1UV-0001qW-Lg; Fri, 25 Jan 2019 14:25:51 +0100 Message-ID: <4f4eab34a995000d230c8b99cb6cff3f9dfd5c64.camel@sipsolutions.net> From: Johannes Berg To: Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= , linux-wireless@vger.kernel.org Cc: Rajkumar Manoharan , ath10k@lists.infradead.org, make-wifi-fast@lists.bufferbloat.net Date: Fri, 25 Jan 2019 14:25:50 +0100 In-Reply-To: <20190122142019.21417-2-toke@redhat.com> (sfid-20190122_152134_612942_99BDC416) References: <20190122142019.21417-1-toke@redhat.com> <20190122142019.21417-2-toke@redhat.com> (sfid-20190122_152134_612942_99BDC416) Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-2.fc28) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Make-wifi-fast] [PATCH v7 1/4] mac80211: Expose ieee80211_schedule_txq() function X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2019 13:25:57 -0000 > +void ieee80211_schedule_txq(struct ieee80211_hw *hw, > + struct ieee80211_txq *txq) > + __acquires(txq_lock) __releases(txq_lock) > +{ > + struct ieee80211_local *local = hw_to_local(hw); > + struct txq_info *txqi = to_txq_info(txq); > + > + spin_lock_bh(&local->active_txq_lock[txq->ac]); > + ieee80211_return_txq(hw, txq); > + spin_unlock_bh(&local->active_txq_lock[ac]); > Maybe v6 had txq->ac here instead of just ac which doesn't compile ;-) I fixed it up, but I hope you tested a compiling version :P johannes