From: Rajkumar Manoharan <rmanohar@codeaurora.org>
To: Jonathan Morton <chromatix99@gmail.com>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
"Kan Yan" <kyan@google.com>,
make-wifi-fast@lists.bufferbloat.net,
linux-wireless-owner@vger.kernel.org,
linux-wireless@vger.kernel.org, "Felix Fietkau" <nbd@nbd.name>
Subject: Re: [Make-wifi-fast] [PATCH RFC v4 3/4] mac80211: Add airtime accounting and scheduling to TXQs
Date: Fri, 28 Sep 2018 03:47:51 -0700 [thread overview]
Message-ID: <586459da6ec36edc2284df8533915d62@codeaurora.org> (raw)
In-Reply-To: <44B09168-C08F-4C85-8D74-D576CCC79880@gmail.com>
On 2018-09-28 03:35, Jonathan Morton wrote:
>> On 28 Sep, 2018, at 1:19 pm, Rajkumar Manoharan
>> <rmanohar@codeaurora.org> wrote:
>>
>>> This is going to break fairness; we only want to increase deficits
>>> when
>>> all stations' deficits are negative. Hence the two loops. Did you see
>>> any problems with those specifically?
>>
>> No. I didn't see any issue but the loop won't exit until one txq
>> becomes positive.
>> Till then the lock won't be released. Hence I converged into single
>> iteration.
>
> The problem is that the fairness behaviour is changed when there are
> already positive txqs, but the first one happens to not be positive.
> That's why there were two loops.
>
Yeah.. Understood. we can ignore the cleanup change.
-Rajkumar
next prev parent reply other threads:[~2018-09-28 10:47 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-16 17:42 [Make-wifi-fast] [PATCH RFC v4 0/4] Move TXQ scheduling into mac80211 Toke Høiland-Jørgensen
2018-09-16 17:42 ` [Make-wifi-fast] [PATCH RFC v4 2/4] cfg80211: Add airtime statistics and settings Toke Høiland-Jørgensen
2018-09-16 17:42 ` [Make-wifi-fast] [PATCH RFC v4 1/4] mac80211: Add TXQ scheduling API Toke Høiland-Jørgensen
2018-09-18 0:57 ` Rajkumar Manoharan
2018-09-18 10:29 ` Toke Høiland-Jørgensen
2018-09-18 18:51 ` Rajkumar Manoharan
2018-09-18 20:41 ` Toke Høiland-Jørgensen
2018-09-18 21:30 ` Rajkumar Manoharan
2018-09-19 9:09 ` Toke Høiland-Jørgensen
2018-09-19 14:43 ` Kalle Valo
2018-09-19 14:50 ` Toke Høiland-Jørgensen
2018-09-19 16:54 ` Rajkumar Manoharan
2018-09-16 17:42 ` [Make-wifi-fast] [PATCH RFC v4 3/4] mac80211: Add airtime accounting and scheduling to TXQs Toke Høiland-Jørgensen
2018-09-26 7:09 ` Rajkumar Manoharan
2018-09-26 9:22 ` Toke Høiland-Jørgensen
2018-09-27 0:09 ` Rajkumar Manoharan
2018-09-28 5:29 ` Rajkumar Manoharan
2018-09-28 7:51 ` Toke Høiland-Jørgensen
2018-09-28 9:27 ` Rajkumar Manoharan
2018-09-28 9:44 ` Rajkumar Manoharan
2018-09-28 9:58 ` Toke Høiland-Jørgensen
2018-09-28 10:19 ` Rajkumar Manoharan
2018-09-28 10:35 ` Jonathan Morton
2018-09-28 10:47 ` Rajkumar Manoharan [this message]
2018-09-28 11:02 ` Toke Høiland-Jørgensen
2018-09-28 19:51 ` Rajkumar Manoharan
2018-10-02 6:58 ` Rajkumar Manoharan
2018-10-02 7:41 ` Rajkumar Manoharan
2018-10-02 8:22 ` Toke Høiland-Jørgensen
2018-10-02 16:33 ` Rajkumar Manoharan
2018-10-02 19:00 ` Toke Høiland-Jørgensen
2018-10-02 23:07 ` Rajkumar Manoharan
2018-10-03 5:53 ` Rajkumar Manoharan
2018-10-03 6:27 ` Rajkumar Manoharan
2018-10-03 8:41 ` Toke Høiland-Jørgensen
2018-09-16 17:42 ` [Make-wifi-fast] [PATCH RFC v4 4/4] ath9k: Switch to mac80211 TXQ scheduling and airtime APIs Toke Høiland-Jørgensen
2018-09-20 21:29 ` [Make-wifi-fast] [PATCH RFC v4 0/4] Move TXQ scheduling into mac80211 Rajkumar Manoharan
2018-09-21 12:41 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/make-wifi-fast.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=586459da6ec36edc2284df8533915d62@codeaurora.org \
--to=rmanohar@codeaurora.org \
--cc=chromatix99@gmail.com \
--cc=kyan@google.com \
--cc=linux-wireless-owner@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=make-wifi-fast@lists.bufferbloat.net \
--cc=nbd@nbd.name \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox