From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-x244.google.com (mail-qk0-x244.google.com [IPv6:2607:f8b0:400d:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 4199E3CB4F for ; Wed, 21 Feb 2018 03:56:40 -0500 (EST) Received: by mail-qk0-x244.google.com with SMTP id f25so1040169qkm.0 for ; Wed, 21 Feb 2018 00:56:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=xV3cYK8PjeE6HzjqjSU7mckDYCSgewx6BBSZ7ted2OI=; b=UJEhWzli7YcS6aaiIggZADGMjWiclq2hZJiCG1Qpe3/IgE/hCwKJpg6oYgXFhtQfqB EQAmDa0PZbKk6vJT/oq8UY6MAhKusOCxM3H5rPxL4+8k3V2xaWzqamveK6g66asI/Ixh WqUmlruNNdI8TGu658DIhrfqpWKfwiJxS4pkE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=xV3cYK8PjeE6HzjqjSU7mckDYCSgewx6BBSZ7ted2OI=; b=FSqh8zVenZkwZKFCUU45o3fcyyCaWuP4zvIWJLQt7Uu1UantjCxPB6kg0RvZ4rvQfi PVV5PGT07xevUA79Vpjbxjq+y0iX/LkJtEa2jqYjaCyGakda02SBfhJTWFhnT0AGORPs Ns0X3S9xr/XQT6meqgttnQeBGsIcPt6R9aOP7SXxb9DRTGPsmCQ8NkwoWE1vAh64lCS8 Dvc3YunBrH/P+YngkKg8n/T3Vy0wSiO8U9SatBnB/xj6Zuwy4JjnfKcBXCEeHIThxqNj JeldEln9vb1hHCwuinjfzp/MseQGDXSZ3dIiHbWxEmME4WMwZVRrn0xKOMv6QQaDD3Xg G80A== X-Gm-Message-State: APf1xPAS3Jem3KK9NDGBLGAb/PFV/tE6T0MoAi19oZHXqDEIyq14WlZ/ VYOwy3BVPL1yZXREDD9USXwArM56G60= X-Google-Smtp-Source: AH8x226Qbr0o0kfpHowEZZNsLhmuxlh5WdMKAWNevD5QttDZW9BGMW8Gg4YGZ/pa5dKeeh6sb/hckg== X-Received: by 10.55.18.135 with SMTP id 7mr4093149qks.7.1519203399780; Wed, 21 Feb 2018 00:56:39 -0800 (PST) Received: from [10.176.68.125] ([192.19.248.250]) by smtp.gmail.com with ESMTPSA id k1sm14677216qkl.89.2018.02.21.00.56.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Feb 2018 00:56:39 -0800 (PST) To: =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= , make-wifi-fast@lists.bufferbloat.net, linux-wireless@vger.kernel.org References: <20180219170224.14816-1-toke@toke.dk> From: Arend van Spriel Message-ID: <5A8D3445.3040300@broadcom.com> Date: Wed, 21 Feb 2018 09:56:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20180219170224.14816-1-toke@toke.dk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Make-wifi-fast] [PATCH 0/3] Export TXQ parameters and statistics via nl80211 X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Feb 2018 08:56:40 -0000 On 2/19/2018 6:02 PM, Toke Høiland-Jørgensen wrote: > This series adds TXQ parameters and statistics that were previously only > available through debugfs to the nl80211 userspace interface and the > cfg80211 kernel interface. Patches for iw to print the statistics and > change the settings are included. So what is your motivation for having this exposed through nl80211. For the average end-user the stats and parameters are fairly fuzzy. So can we expect some manual in which is described what parameter should be tweaked based on the retrieved statistics. Also do you intend to remove the debugfs method? Seems a bit redundant to have two mostly identical interfaces in place. > Wasn't sure whether to include the updates to nl80211.h in the iw > patchset, so I didn't :) Updating the nl80211.h in iw should be done with a copy from the kernel so it has to wait for the kernel patch to be applied (which tree I am unsure). Regards, Arend > -Toke > > > Kernel patch: > > Toke Høiland-Jørgensen (1): > cfg80211: Expose TXQ stats and parameters to userspace > > include/net/cfg80211.h | 52 +++++++++++++++++++ > include/uapi/linux/nl80211.h | 57 +++++++++++++++++++++ > net/mac80211/cfg.c | 95 +++++++++++++++++++++++++++++++++++ > net/mac80211/ieee80211_i.h | 3 ++ > net/mac80211/main.c | 3 ++ > net/mac80211/sta_info.c | 12 +++++ > net/mac80211/tx.c | 20 ++++++++ > net/wireless/nl80211.c | 115 +++++++++++++++++++++++++++++++++++++++++++ > net/wireless/rdev-ops.h | 12 +++++ > net/wireless/trace.h | 14 ++++++ > 10 files changed, 383 insertions(+) > > > iw patches (updated nl80211.h not included): > > Toke Høiland-Jørgensen (2): > iw: Print TXQ statistics for stations and interfaces > iw: Add getting and setting of TXQ params for phy > > info.c | 3 ++ > interface.c | 6 ++++ > iw.h | 2 ++ > phy.c | 116 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > station.c | 91 ++++++++++++++++++++++++++++++++++++++++++++++- > 5 files changed, 217 insertions(+), 1 deletion(-) >