From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-x229.google.com (mail-wr0-x229.google.com [IPv6:2a00:1450:400c:c0c::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id E78193CB3F for ; Wed, 21 Feb 2018 14:53:32 -0500 (EST) Received: by mail-wr0-x229.google.com with SMTP id 34so7811528wre.13 for ; Wed, 21 Feb 2018 11:53:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding; bh=lYHfM4Tnz68ctVJykQyfOfNRRGrU+iS36zAPmDMsnRg=; b=N3UCvnE97gx0fit8voEi+RKKvzSMfafhTuJOIC5dZzpavO3uLzgHWC71CZLgWw9Hw2 Z/uAKnph9A77VYlEHSo5CpkcIZZU6UOXJRXdLn83DuxVakNcsjlYafP/lZnL10j8+Ic+ vYbsDOgayhn5VAMeDc9uFcEWaLrrHO5wzZYj0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=lYHfM4Tnz68ctVJykQyfOfNRRGrU+iS36zAPmDMsnRg=; b=pum7wpsGknEddq9p3hm0S3yaxxjvg3YCOpVuQbbMX1zfoKl4puFkLFezgOe8tKRlQR RfJRSG+61+Zpss8Fw8Q1kiEDuTi7zfCbs0xBLKoWk6JXwUNXVRiTz/ovduTjcMs9XOXu SwfqBzqVD0eMbXwMU5i40FuHqVmKyFEWQ6txtw0ffmhwxqFRys8YdESe6fMwChVao/bs /tpF8L940uGVOg4MfRjCj/G0QLhA2C/gTMthoX1lCIql9FEaZuaxod4f5QpABo4SMkMl wxX/rD3p2OcRud39u65n7O4tjrmXaP45EOXj404IE4J/3TrC0uQqIiGmYxC2s2bwfvQC OJkg== X-Gm-Message-State: APf1xPB0WLx8NRHq2wulPlhlABcPbona0W1MWlad64lVKUjNKtjrAOD5 3HmuFsYN5WSVr8WWnyWgn4lnpQ== X-Google-Smtp-Source: AH8x227/RNLMQg6t0z8I0h5YltQ7BOpWePprqwQsOEyHo7ONC2eq06B00P6njWDz2LSe8qnP1UoaPQ== X-Received: by 10.80.208.195 with SMTP id g3mr6484514edf.63.1519242811983; Wed, 21 Feb 2018 11:53:31 -0800 (PST) Received: from [192.168.178.129] (f140230.upc-f.chello.nl. [80.56.140.230]) by smtp.gmail.com with ESMTPSA id v34sm6916265edm.91.2018.02.21.11.53.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Feb 2018 11:53:31 -0800 (PST) To: =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= , make-wifi-fast@lists.bufferbloat.net, linux-wireless@vger.kernel.org References: <20180219170224.14816-1-toke@toke.dk> <5A8D3445.3040300@broadcom.com> <87bmgiboan.fsf@toke.dk> From: Arend van Spriel Message-ID: <5A8DCE3B.3000607@broadcom.com> Date: Wed, 21 Feb 2018 20:53:31 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <87bmgiboan.fsf@toke.dk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Make-wifi-fast] [PATCH 0/3] Export TXQ parameters and statistics via nl80211 X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Feb 2018 19:53:33 -0000 On 2/21/2018 12:00 PM, Toke Høiland-Jørgensen wrote: > Arend van Spriel writes: > >> On 2/19/2018 6:02 PM, Toke Høiland-Jørgensen wrote: >>> This series adds TXQ parameters and statistics that were previously only >>> available through debugfs to the nl80211 userspace interface and the >>> cfg80211 kernel interface. Patches for iw to print the statistics and >>> change the settings are included. >> >> So what is your motivation for having this exposed through nl80211. >> For the average end-user the stats and parameters are fairly fuzzy. > > Two reasons, basically: > > 1. Visibility and statistics; this is basically the same information > that is available at the qdisc layer (with `tc -s qdisc`), but which > has been missing on WiFi interfaces ever sine we switched to the TXQ > structure. Having this available has been quite valuable for > debugging qdisc setups on wired links, and it's not always feasible > to ask users to recompile their kernels with debugfs enabled. > > 2. Having visibility into the queues from userspace makes it possible to > make decisions based upon (e.g.) which stations are currently > backlogged. I'm working on a "policy mode" for the airtime fairness > scheduler which will use this capability. I see. Was just wondering whether there were concrete user-space applications planned to use the information. Cool. >> So can we expect some manual in which is described what parameter >> should be tweaked based on the retrieved statistics. > > Heh, not sure I'll promise a whole manual, but I am happy to write a > blog post (or wiki page if that's better) explaining what these values > mean and what insight one might gain from them. My preference would be to have something on wireless.wiki.kernel.org. Another option might be to add kerneldoc section for this. Regards, Arend