From: Johannes Berg <johannes@sipsolutions.net>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>,
linux-wireless@vger.kernel.org
Cc: Felix Fietkau <nbd@nbd.name>,
Rajkumar Manoharan <rmanohar@codeaurora.org>,
Kan Yan <kyan@google.com>,
make-wifi-fast@lists.bufferbloat.net,
Yibo Zhao <yiboz@codeaurora.org>
Subject: Re: [Make-wifi-fast] [PATCH v5] mac80211: Switch to a virtual time-based airtime scheduler
Date: Thu, 02 Jan 2020 15:13:55 +0100 [thread overview]
Message-ID: <5bab549a72d526f4fd0f708f14b49a7af6e2c0b9.camel@sipsolutions.net> (raw)
In-Reply-To: <20191222172423.131033-1-toke@redhat.com> (sfid-20191222_182529_460296_FED7C003)
On Sun, 2019-12-22 at 18:24 +0100, Toke Høiland-Jørgensen wrote:
> Didn't have a chance to
> do anything other than compile-test it yet, but wanted to get it out
> before the holidays (which I almost managed, since technically my
> holiday started two days ago)...
Didn't help you much, I at least was already on vacation by then too :P
> @@ -1948,6 +1978,7 @@ void ieee80211_sta_update_pending_airtime(struct ieee80211_local *local,
> tx_pending, 0);
> }
>
> +
nit, what's that doing here? :)
> +#define IEEE80211_RECIPROCAL_DIVISOR 0x100000000ULL
> +#define IEEE80211_RECIPROCAL_SHIFT 32
Could we live with less precision and use 32-bit arithmetic only? That
might help 32-bit systems?
This is basically a 32.32 (31.32 for signed) fixed point number, right?
So I guess I'm asking if we could live with 16.16 (or 15.16), or
similar.
> @@ -525,6 +532,7 @@ struct ieee80211_sta_rx_stats {
> * @status_stats.ack_signal_filled: last ACK signal validity
> * @status_stats.avg_ack_signal: average ACK signal
> */
> +
another pointless blank line
> + air_info = to_airtime_info(&txqi->txq);
> + ret = (air_info->v_t <= air_sched->v_t);
no need for parentheses :)
I think overall this looks good. I guess you should subject it to some
testing since I can't.
johannes
next prev parent reply other threads:[~2020-01-02 14:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-22 17:24 Toke Høiland-Jørgensen
2020-01-02 14:13 ` Johannes Berg [this message]
2020-01-06 15:20 ` Toke Høiland-Jørgensen
2020-01-06 15:47 ` John Yates
2020-01-06 15:54 ` Toke Høiland-Jørgensen
2020-01-06 22:19 ` John Yates
2020-01-07 10:43 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/make-wifi-fast.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bab549a72d526f4fd0f708f14b49a7af6e2c0b9.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=kyan@google.com \
--cc=linux-wireless@vger.kernel.org \
--cc=make-wifi-fast@lists.bufferbloat.net \
--cc=nbd@nbd.name \
--cc=rmanohar@codeaurora.org \
--cc=toke@redhat.com \
--cc=yiboz@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox