From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 0CB323B29E for ; Thu, 2 Jan 2020 09:14:01 -0500 (EST) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.92.3) (envelope-from ) id 1in1Ea-005WoJ-Qk; Thu, 02 Jan 2020 15:13:56 +0100 Message-ID: <5bab549a72d526f4fd0f708f14b49a7af6e2c0b9.camel@sipsolutions.net> From: Johannes Berg To: Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= , linux-wireless@vger.kernel.org Cc: Felix Fietkau , Rajkumar Manoharan , Kan Yan , make-wifi-fast@lists.bufferbloat.net, Yibo Zhao Date: Thu, 02 Jan 2020 15:13:55 +0100 In-Reply-To: <20191222172423.131033-1-toke@redhat.com> (sfid-20191222_182529_460296_FED7C003) References: <20191222172423.131033-1-toke@redhat.com> (sfid-20191222_182529_460296_FED7C003) Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 (3.34.2-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [Make-wifi-fast] [PATCH v5] mac80211: Switch to a virtual time-based airtime scheduler X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jan 2020 14:14:01 -0000 On Sun, 2019-12-22 at 18:24 +0100, Toke Høiland-Jørgensen wrote: > Didn't have a chance to > do anything other than compile-test it yet, but wanted to get it out > before the holidays (which I almost managed, since technically my > holiday started two days ago)... Didn't help you much, I at least was already on vacation by then too :P > @@ -1948,6 +1978,7 @@ void ieee80211_sta_update_pending_airtime(struct ieee80211_local *local, > tx_pending, 0); > } > > + nit, what's that doing here? :) > +#define IEEE80211_RECIPROCAL_DIVISOR 0x100000000ULL > +#define IEEE80211_RECIPROCAL_SHIFT 32 Could we live with less precision and use 32-bit arithmetic only? That might help 32-bit systems? This is basically a 32.32 (31.32 for signed) fixed point number, right? So I guess I'm asking if we could live with 16.16 (or 15.16), or similar. > @@ -525,6 +532,7 @@ struct ieee80211_sta_rx_stats { > * @status_stats.ack_signal_filled: last ACK signal validity > * @status_stats.avg_ack_signal: average ACK signal > */ > + another pointless blank line > + air_info = to_airtime_info(&txqi->txq); > + ret = (air_info->v_t <= air_sched->v_t); no need for parentheses :) I think overall this looks good. I guess you should subject it to some testing since I can't. johannes