From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wolverine01.qualcomm.com (wolverine01.qualcomm.com [199.106.114.254]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 7166A3B2A0 for ; Wed, 9 Nov 2016 17:42:56 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=qca.qualcomm.com; i=@qca.qualcomm.com; q=dns/txt; s=qcdkim; t=1478731376; x=1510267376; h=mime-version:content-transfer-encoding:subject:from: in-reply-to:references:to:cc:message-id:date; bh=wU8V12GjrFwlurxyFKOfDiwKRGYxdrfwxlZnNsoEAss=; b=q+q366SUtU38LSgkB5KSNEe6ftZuBVNZXZccg63DFEwtyihzJX6fn3RS nlohd0O90gOlp6/tu1eEGO6D1nDf72OFH02llx31oYVjFQEIoXhTdEndH XZo68zLO9cBRO3QoPymnSMZSK4e7UdLsM+fzF5x2jG3nrRgeTNJLd3rFv g=; X-IronPort-AV: E=Sophos;i="5.31,615,1473145200"; d="scan'208";a="238885791" Received: from unknown (HELO Ironmsg04-R.qualcomm.com) ([10.53.140.108]) by wolverine01.qualcomm.com with ESMTP; 09 Nov 2016 14:42:55 -0800 X-IronPort-AV: E=McAfee;i="5700,7163,8344"; a="1307948971" Received: from nasanexm02a.na.qualcomm.com ([10.85.0.41]) by Ironmsg04-R.qualcomm.com with ESMTP/TLS/RC4-SHA; 09 Nov 2016 14:42:54 -0800 Received: from euamsexm01a.eu.qualcomm.com (10.251.127.40) by nasanexm02a.na.qualcomm.com (10.85.0.41) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Wed, 9 Nov 2016 14:42:53 -0800 Received: from potku.adurom.net (10.80.80.8) by euamsexm01a.eu.qualcomm.com (10.251.127.40) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Wed, 9 Nov 2016 23:42:47 +0100 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Kalle Valo In-Reply-To: <20161109113149.5724-1-toke@toke.dk> References: <20161109113149.5724-1-toke@toke.dk> To: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= CC: , , =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Tim Shepard , Felix Fietkau User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.3 Message-ID: <689eea51fa77432cbe4c70c6c2fe7b13@euamsexm01a.eu.qualcomm.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanexm01a.na.qualcomm.com (10.85.0.81) To euamsexm01a.eu.qualcomm.com (10.251.127.40) X-Mailman-Approved-At: Mon, 28 Nov 2016 08:47:10 -0500 Subject: Re: [Make-wifi-fast] [v6] ath9k: Switch to using mac80211 intermediate software queues. X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Wed, 09 Nov 2016 22:42:56 -0000 X-Original-Date: Wed, 9 Nov 2016 23:42:47 +0100 X-List-Received-Date: Wed, 09 Nov 2016 22:42:56 -0000 Toke Høiland-Jørgensen wrote: > This switches ath9k over to using the mac80211 intermediate software > queueing mechanism for data packets. It removes the queueing inside the > driver, except for the retry queue, and instead pulls from mac80211 when > a packet is needed. The retry queue is used to store a packet that was > pulled but can't be sent immediately. > > The old code path in ath_tx_start that would queue packets has been > removed completely, as has the qlen limit tunables (since there's no > longer a queue in the driver to limit). > > The mac80211 intermediate software queues offer significant latency > reductions, and this patch allows ath9k to realise them. The exact gains > from this varies with the test scenario, but in an access point scenario > we have seen latency reductions ranging from 1/3 to as much as an order > of magnitude. We also achieve slightly better aggregation. > > Median latency (ping) figures with this patch applied at the access point, > with two high-rate stations and one low-rate station (HT20 5Ghz), running > a Flent rtt_fair_var_up test with one TCP flow and one ping flow going to > each station: > > Fast station Slow station > Default pfifo_fast qdisc: 430.4 ms 638.7 ms > fq_codel qdisc on iface: 35.5 ms 211.8 ms > This patch set: 22.4 ms 38.2 ms > > Median aggregation sizes over the same test: > > Default pfifo_fast qdisc: 9.5 pkts 1.9 pkts > fq_codel qdisc on iface: 11.2 pkts 1.9 pkts > This patch set: 13.9 pkts 1.9 pkts > > This patch is based on Tim's original patch set, but reworked quite > thoroughly. > > Cc: Tim Shepard > Cc: Felix Fietkau > Signed-off-by: Toke Høiland-Jørgensen Perfect, just what I was hoping to see :) Unless something really surprising comes up I should apply this within the next few days. -- https://patchwork.kernel.org/patch/9419029/ Documentation about submitting wireless patches and checking status from patchwork: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches