From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rmanohar@codeaurora.org>
Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by lists.bufferbloat.net (Postfix) with ESMTPS id 7C81A3CB36
 for <make-wifi-fast@lists.bufferbloat.net>;
 Thu, 20 Sep 2018 17:29:20 -0400 (EDT)
Received: by smtp.codeaurora.org (Postfix, from userid 1000)
 id 9530560818; Thu, 20 Sep 2018 21:29:19 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;
 s=default; t=1537478959;
 bh=Wfw8zHy+NxeOSSqOH9a0Sv091Vn383F/OvbBxgco1Ec=;
 h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
 b=AEBMOogJa0ce4Mz/1BqYma90sLnPLSAZlh4j5kLY7BcowOuN44H/VrJufavuF2h9u
 3xbIzxQ18SHOpSnsIOIASKF9BLE27F6sBBQqR4iiC3DKQNMHVGuTUiR0yHSg2jkLJ5
 +GkFOozC4RUiloYe9bv57YG6NuWipEBqR15B5/Ao=
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
 pdx-caf-mail.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0
Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1])
 by smtp.codeaurora.org (Postfix) with ESMTP id 3DA7D60558;
 Thu, 20 Sep 2018 21:29:19 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org;
 s=default; t=1537478959;
 bh=Wfw8zHy+NxeOSSqOH9a0Sv091Vn383F/OvbBxgco1Ec=;
 h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
 b=AEBMOogJa0ce4Mz/1BqYma90sLnPLSAZlh4j5kLY7BcowOuN44H/VrJufavuF2h9u
 3xbIzxQ18SHOpSnsIOIASKF9BLE27F6sBBQqR4iiC3DKQNMHVGuTUiR0yHSg2jkLJ5
 +GkFOozC4RUiloYe9bv57YG6NuWipEBqR15B5/Ao=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Date: Thu, 20 Sep 2018 14:29:19 -0700
From: Rajkumar Manoharan <rmanohar@codeaurora.org>
To: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
Cc: linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net,
 Felix Fietkau <nbd@nbd.name>, Kan Yan <kyan@google.com>
In-Reply-To: <153711966150.9231.13481453399723518107.stgit@alrua-x1>
References: <153711966150.9231.13481453399723518107.stgit@alrua-x1>
Message-ID: <6f97d6300d514c0b6577c9c9376b98a8@codeaurora.org>
X-Sender: rmanohar@codeaurora.org
User-Agent: Roundcube Webmail/1.2.5
Subject: Re: [Make-wifi-fast] [PATCH RFC v4 0/4] Move TXQ scheduling into
	mac80211
X-BeenThere: make-wifi-fast@lists.bufferbloat.net
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: <make-wifi-fast.lists.bufferbloat.net>
List-Unsubscribe: <https://lists.bufferbloat.net/options/make-wifi-fast>,
 <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=unsubscribe>
List-Archive: <https://lists.bufferbloat.net/pipermail/make-wifi-fast>
List-Post: <mailto:make-wifi-fast@lists.bufferbloat.net>
List-Help: <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=help>
List-Subscribe: <https://lists.bufferbloat.net/listinfo/make-wifi-fast>,
 <mailto:make-wifi-fast-request@lists.bufferbloat.net?subject=subscribe>
X-List-Received-Date: Thu, 20 Sep 2018 21:29:20 -0000

On 2018-09-16 10:42, Toke Høiland-Jørgensen wrote:
> Another update, addressing most of the concerns raised in the last 
> round:
> 
> - Added schedule_start()/end() functions that adds locking around the
>   whole scheduling operation, which means we can get rid of the 'first'
>   parameter to ieee80211_next_txq().
> 
Toke,

Wouldn't this start()/end() APIs cause deadlock if mac80211 tries to 
acquire
active_txq_lock[ac] again? Or am I missing?

schedule_start()
while (next_txq()) {
   push_txq -> tx_dequeue()
   return_txq()
}
schedule_end()

tx_dequeue()
  ieee80211_free_txskb
   -> ieee80211_report_used_skb
    -> ieee80211_tdls_td_tx_handle
     -> ieee80211_subif_start_xmit
     -> __ieee80211_subif_start_xmit
       -> ieee80211_xmit_fast
         -> ieee80211_queue_skb
          -> schedule_and_wake_txq

-Rajkumar