From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 7965C3B29E for ; Tue, 22 Oct 2019 07:35:21 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571744120; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9lXUdIMpqZFihIoO9yzChXD19YUfn5jCLlrdTWpXVmA=; b=iP2HoLjmLiufh1DkrEYCKd4bip/ndHdFXgwxnpDSypcQa2YApcetRNT0fOrA7CjmcT7+/r BmqvXv0lfIVXSMuABz62lj9MqsOLKayMfr4ls3AiqpBykmqR8C+jbu9ZQUtiuGvE6zMz8M Y5GSsHRJQ5OL02srNSF6rhEmIEfEo4A= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-226-F8nAaVLpMW-wbNSRztASCg-1; Tue, 22 Oct 2019 07:35:19 -0400 Received: by mail-lj1-f198.google.com with SMTP id 5so2875574lje.12 for ; Tue, 22 Oct 2019 04:35:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=5Z4MpTbIw+JCQPCzaEXbau+RX+9w+zSZ8KSShaRJy8k=; b=KttJhzdPUDb2Y3IojZ9l+GFR8yGLvdUK443AMtZEnM33lixCGzGcdXdHn/LxOV7VAy TNbzWKOgwZ/81hKVhCuyVaBiPryfaNt9S8Cv4VaREjehy4ke1PP3j8OXYaHeA95slmAu eMkHnqC9ZEQ34uw7qw7g66IJqpyZunIUzVYmIpH9C7e4aLbCty3Oh4/pNWdmpAtfuIUi Q3mK+PfxCEGbnHOk2lNv55WizCrB7I6rNe9AyLjjFWO3YBYH4o1/S/hjAJ/Xz5+yI6ig c7anOeUDw5N9k9U9i1on1Vp8kjK/ttXCpewfLPZD+T3cQXrxfI2FkLgzWlzVrAx5rUaI 8V+Q== X-Gm-Message-State: APjAAAX45etHb+swugWpdVzr8FIIKRtcIg1lsb84vGzX7eM5MglsX1JT njInGgpBZFYj0ehPdqXfgdeAmJM7lJgXBPyMNGe+UrTlcufrLZPjiVnbG/pYVUbgHmcIDMTKQdA ctL5FdqiiZafUF9O+5eo+Lpwp2Rcgfw55SGg= X-Received: by 2002:a19:6a08:: with SMTP id u8mr19884676lfu.74.1571744117868; Tue, 22 Oct 2019 04:35:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqwmGTFXAJkFuoNzgelmQogIQSog/uQu9muSz0RpmB3Wbx+A4SlxIO3hShCl4fhxL63M2txo1g== X-Received: by 2002:a19:6a08:: with SMTP id u8mr19884659lfu.74.1571744117720; Tue, 22 Oct 2019 04:35:17 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk (borgediget.toke.dk. [85.204.121.218]) by smtp.gmail.com with ESMTPSA id b67sm16614489ljf.5.2019.10.22.04.35.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2019 04:35:16 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 2DABF1804B1; Tue, 22 Oct 2019 13:35:16 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Kan Yan Cc: Johannes Berg , linux-wireless@vger.kernel.org, Make-Wifi-fast , ath10k@lists.infradead.org, John Crispin , Lorenzo Bianconi , Felix Fietkau , Rajkumar Manoharan , Kevin Hayes In-Reply-To: References: <157148503415.2989444.7391437309981941226.stgit@toke.dk> <157148503865.2989444.7118792679603045723.stgit@toke.dk> X-Clacks-Overhead: GNU Terry Pratchett Date: Tue, 22 Oct 2019 13:35:16 +0200 Message-ID: <871rv5ovwr.fsf@toke.dk> MIME-Version: 1.0 X-MC-Unique: F8nAaVLpMW-wbNSRztASCg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH v4 4/4] mac80211: Use Airtime-based Queue Limits (AQL) on packet dequeue X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Oct 2019 11:35:21 -0000 Kan Yan writes: >> + if (ieee80211_is_data_qos(hdr->frame_control)) { >> + qc =3D ieee80211_get_qos_ctl(hdr); >> + tid =3D qc[0] & 0xf; >> + ac =3D ieee80211_ac_from_tid(tid); >> + } else { >> + ac =3D IEEE80211_AC_BE; >> + } > > The tid/ac is incorrect either here or in __ieee80211_tx_status() when > tested with ath10k. The ac is set to AC_BE with test done using BK > class traffic, hence the pending airtime get updated for the wrong > txq. Hmm, I guess we could just get the ac using skb_get_queue_mapping(). I'll send an update with this fixed for you to try :) -Toke