From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [52.28.52.200]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id AF1E43B2A4 for ; Tue, 17 Oct 2017 06:09:52 -0400 (EDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1508234989; bh=qoA7Y3rDghrCPYGQBQms+r+RfUM+qrBTJ1/tTieIPQ0=; h=From:To:Subject:In-Reply-To:References:Date:From; b=H9cWTTYqcc+kucW8pYrxbFo8TvECpfZ15YM1R5pYxho/XeQqapYPp3Je1t3OmvHgo /uHGqZNzrrf2ihsTKuTumSS2YZWXD+rvOlEbHceUPivpfqRpmiA/0ByXFzYFYLIrsj 20HBsJE82LbuKhbUKXH41MHdq3qMb7kSupUZGlM4nRfx+tXKpo/h+C3ypH4zNfM2yo LpiS3TD1uKaatmjBf60FEFMsFe5Egx5wqn7uTamCMTZZsEGibfU9XZ5m2GbxX3rgUX GrYf9ci9WY/QII+jrfVQkXoThHOENw+QCCA/Xz1CUjE4KOJREZ6A54GUb0764NOg+H ja6nYwvtj49Ng== To: Johannes Berg , make-wifi-fast@lists.bufferbloat.net, linux-wireless@vger.kernel.org In-Reply-To: <1508234443.10607.72.camel@sipsolutions.net> References: <20171016160902.8970-1-toke@toke.dk> <20171016160902.8970-2-toke@toke.dk> <1508224046.10607.67.camel@sipsolutions.net> <871sm2p6rt.fsf@toke.dk> <1508234443.10607.72.camel@sipsolutions.net> Date: Tue, 17 Oct 2017 12:09:48 +0200 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <871sm29jbn.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH 2/2] mac80211: Add airtime accounting and scheduling to TXQs X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Oct 2017 10:09:52 -0000 Johannes Berg writes: > On Tue, 2017-10-17 at 09:34 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wrote: > >> Yeah, I did that initially. The reason I ended up squashing them is >> that >> this patch moved the per-station 'airtime' debugfs-entry that was >> previously created by ath9k into mac80211. I assumed it would create >> problems if both the driver and mac80211 tried to create the same >> file; >> not sure how to handle that if it's split into two patches? > > That might indeed be problematic, so perhaps just use a different > name? Well I would like to keep compatibility with my tooling that reads the values :) > Then again, if adding the entry fails in ath9k, nothing will happen > since it doesn't even check the return value - so I think it doesn't > actually matter. Right, I'll try that, and otherwise create a separate patch to ath9k that removes the debugfs entry before applying the mac80211 patch. >> > I'd prefer this were called "airtime" or such, >>=20 >> Right. I picked rx_time for symmetry with the tx side; should I >> rename that as well, then, or is asymmetry fine? > > Let's not change the tx side in this patch, but we can clean it up > later I guess. ACK. -Toke