From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id D7B203B29D for ; Thu, 27 Feb 2020 05:17:14 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582798634; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0PpLC53FANPq6vRlUJYRXGgc8q+rsvi0q/hoodttMho=; b=CRDwi3ERYa0qrRWYihj4Nw6ZBNdDhEdYYhrQcwl6gQkdu6tVoT3vtJpmW+LmZv7NpR3DsJ sZTaevedK6AFbnWC8xEgD1XYsPMf5Jtws6On/UnlY4Up0GC1QExxWe/9J24G3/CVqYq6Mz tBa4fC/q8QartebTKAnX+XwqVsgnVwk= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-15-aADGXXDNNPmMPFE6qL_Auw-1; Thu, 27 Feb 2020 05:17:08 -0500 X-MC-Unique: aADGXXDNNPmMPFE6qL_Auw-1 Received: by mail-wr1-f72.google.com with SMTP id z1so1106598wrs.9 for ; Thu, 27 Feb 2020 02:17:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=6cHViURCnyaA04HbDOwPN4x7F/IzyCt5NThZd0ymuHg=; b=JOi02Uu36ji9m80bv3IoBiooJ1kQ5v5CkRd5ALV0P05slLVfG3eP6p70e/Z5Vx8fNU Wvpnunna4QKejmsf7mt2+JVc/GdPdYDsgU9C1Odq3XrNszBG0raH4XAz578axD/f/ErY +NSY1AAeiNCkKw0zRbS7XC31936EhmgJYIGbawitnvGavZ+axnmUqTBLVH9vjo+YqSVc OEr9dkMN7u+p5swCn+Uqr8Jjk4+WAgmeKWl57NdUSoNGgmJSCSGUwnC0Cu1YK3v5FDPR XEkxOY9/rfWilKnUuDljJ+kMfFn9UJkr0pVySZpezBG4dAvqTHNRxq+6M3yvgDRvDBMK QGrQ== X-Gm-Message-State: APjAAAW9fp1jRWHNDyrNgW3q4KeBoRoBkM614AM9yky8ILPOqzwY/Gpt ovvSJU/DLF1QJxNhNtiWEa8ZtTypqmhD1f7zegyTT3dLOG7/ldIXI0Zz30328KX5BroJbbv0ml0 OyIufRS/Csiwqcva3zdOQiLuXpHgMgiHwLEI= X-Received: by 2002:a1c:38c7:: with SMTP id f190mr4256841wma.94.1582798627391; Thu, 27 Feb 2020 02:17:07 -0800 (PST) X-Google-Smtp-Source: APXvYqyr76tDTisRMWVLc1Qqj9VVSwpf7gt3eGTCEoI9WVe0SmI/2My10BjYcOOGXcrjYURxfYTVeg== X-Received: by 2002:a1c:38c7:: with SMTP id f190mr4256808wma.94.1582798627098; Thu, 27 Feb 2020 02:17:07 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([45.145.92.2]) by smtp.gmail.com with ESMTPSA id q3sm7043082wmj.38.2020.02.27.02.17.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2020 02:17:06 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id E10FB180362; Thu, 27 Feb 2020 11:17:05 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Justin Capella Cc: Johannes Berg , linux-wireless , make-wifi-fast@lists.bufferbloat.net, nbd@nbd.name, Yibo Zhao , John Crispin , lorenzo@kernel.org, rmanohar@codeaurora.org, kevinhayes@google.com, Kan Yan In-Reply-To: References: <20191119060610.76681-1-kyan@google.com> <20191119060610.76681-5-kyan@google.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Thu, 27 Feb 2020 11:17:05 +0100 Message-ID: <8736awxrku.fsf@toke.dk> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH v11 4/4] mac80211: Use Airtime-based Queue Limits (AQL) on packet dequeue X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Feb 2020 10:17:14 -0000 Justin Capella writes: >> ieee80211_report_used_skb(). As an optimisation, we also subtract the >> airtime on regular TX completion, zeroing out the value stored in the >> packet afterwards, to avoid having to do an expensive lookup of the stat= ion >> from the packet data on every packet. >> >> This patch does *not* include any mechanism to wake a throttled TXQ agai= n, >> on the assumption that this will happen anyway as a side effect of whate= ver >> freed the skb (most commonly a TX completion). > > I recall a recent patch for ath10k sdio that disabled tx > acknowledgement for performance gains and am wondering if that will be > problematic? Presumably not since it would be caught at the dequeue, > but thought I'd ask-- wondering what the effect of failed tx's or > block acknowledgement is on this stuff I'll need to study the code > some more > > https://lore.kernel.org/linux-wireless/0101016eb1903db0-ef7063b4-0f42-4a0= 1-8886-327541e6c1a4-000000@us-west-2.amazonses.com/T/#t It looks like that patch will just end up disabling AQL (because packets will be immediately completed as far as mac80211 is concerned) and replace it with whatever that credit-based scheme does? No idea how that will impact latency; you should go ask the developers of that series! As usual, the patch description only mentions throughput numbers :/ -Toke