From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.toke.dk (mail.toke.dk [IPv6:2001:470:dc45:1000::1]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id BE37C3CB35 for ; Wed, 19 Sep 2018 10:50:26 -0400 (EDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1537368625; bh=pjSUo/b50e30IzUtAXfI3qzOhq02z0al3Fy2N1cJ/Vw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=kI5JZ8VSa6DdIjsRspJTm5hPXo0/wCWWvDMp9h0D+XCOqdWhvCFGqPsOQHiW2K1zf rRfYEDeOWusMSsAg0FnxekMkGJ6MbszWT5HMfOqAq953Jx8gB1pHAPv5KW5jRsqMlK SObasWanXWjdkHHXnq14LDBr5DKuqjMibM1ICt1PedZPFXMRd59np8tGhg/L2Kf6yS sA/NimqQNuNGvHW/vANk3JYEguLthNjVV5auxGlxxcgSpTFgv3vnQMtdEDnJ3a8enJ 58M4C0+fLaC8ut+KHe+lwptZze316HseJj5bwXPsEZRFw5cq5neLzzMIGWK5TdprgV nCsMA1j8BsF+w== To: Kalle Valo Cc: Rajkumar Manoharan , linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net, Felix Fietkau , Kan Yan , linux-wireless-owner@vger.kernel.org In-Reply-To: <878t3xsg3h.fsf@purkki.adurom.net> References: <153711966150.9231.13481453399723518107.stgit@alrua-x1> <153711973109.9231.7094211814263758096.stgit@alrua-x1.karlstad.toke.dk> <13400b5f9bdb5e36c6afabd071cc7b0d@codeaurora.org> <87o9cvksiv.fsf@toke.dk> <87efdq8rn0.fsf@toke.dk> <5e2612cbd4ea9f560a63149c599f8587@codeaurora.org> <87y3bxkg5p.fsf@toke.dk> <878t3xsg3h.fsf@purkki.adurom.net> Date: Wed, 19 Sep 2018 16:50:25 +0200 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <8736u5k0cu.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH RFC v4 1/4] mac80211: Add TXQ scheduling API X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Sep 2018 14:50:26 -0000 Kalle Valo writes: > Toke H=C3=B8iland-J=C3=B8rgensen writes: > >>> Unfortunately ath10k is not reporting last_tx_rate in tx_status(). So >>> I also applied this "ath10k: report tx rate using ieee80211_tx_status" >>> change. >> >> Yeah, that and the patch that computes the last used rate will probably >> be necessary; but they can be pretty much applied as-is, right? > > Unfortunately not. I think the plan is now to follow Johannes' proposal: > > "I'd recommend against doing this and disentangling the necessary > code in mac80211, e.g. with ieee80211_tx_status_ext() or adding > similar APIs." > > https://patchwork.kernel.org/patch/10353959/ Ahh, right... *that* patch :) Was thinking on this one with the "as-is" comment: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/= 588189 -Toke