From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail2.tohojo.dk (mail2.tohojo.dk [77.235.48.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 1E7C83B25D for ; Thu, 1 Sep 2016 04:38:25 -0400 (EDT) X-Virus-Scanned: amavisd-new at mail2.tohojo.dk DKIM-Filter: OpenDKIM Filter v2.10.3 mail2.tohojo.dk BFAD24161D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=201310; t=1472719102; bh=gRXzE4qpr4KOi38nCEnAF2ToiS1ahk9AwgHHSzpNxP0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=poRrRNleEsETjvudt3BuPphTRWr15GbqhziU9zHNILmCnhFt3h3chplp/SggpG1cG TRD3FNtkAXbcGG1F5pxztdEzyTt6UAHL7PwKCr7DSqPaZ+bXaALd5yG2Re27f5i6/t w9c55zHOiV8EPXRDTfGxGWCWwFsaNFQA1vsyNaF0= Received: by alrua-karlstad.karlstad.toke.dk (Postfix, from userid 1000) id 0E0E28283D3; Thu, 1 Sep 2016 10:38:22 +0200 (CEST) From: =?utf-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= To: Johannes Berg Cc: make-wifi-fast@lists.bufferbloat.net, linux-wireless@vger.kernel.org References: <20160824162015.29933-1-toke@toke.dk> <20160830131548.6014-1-toke@toke.dk> <1472677599.5470.13.camel@sipsolutions.net> <87inug81vo.fsf@toke.dk> <1472718860.4249.0.camel@sipsolutions.net> Date: Thu, 01 Sep 2016 10:38:22 +0200 In-Reply-To: <1472718860.4249.0.camel@sipsolutions.net> (Johannes Berg's message of "Thu, 01 Sep 2016 10:34:20 +0200") X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <8737lk816p.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Make-wifi-fast] [PATCH v4] mac80211: Move reorder-sensitive TX handlers to after TXQ dequeue. X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Sep 2016 08:38:25 -0000 Johannes Berg writes: >> > > +static int invoke_tx_handlers(struct ieee80211_tx_data *tx) >> > > +{ >> > > + return invoke_tx_handlers_early(tx) || >> > > invoke_tx_handlers_late(tx); >> > > +} >> > >> > Ugh, please, no, don't be tricky where it's not necessary. Now >> > every >> > person reading this has to first look up the return type, and then >> > the >> > return value, and make sure they understand that success is >> > actually >> > the value 0 ... that's way too much to ask. >> >> Noted. Any objections to turning these into bool return types? > > They have three possible values ... :) Ah, no, not the handlers themselves. Meant the invoke_tx_handlers() function (or all three of them after my patch; hence the plural). To avoid the "0 means true" confusion you alluded to :) -Toke