From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 7873C3B29D for ; Fri, 22 Nov 2019 09:41:46 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574433705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9q597YADqqlOEAZ+us4YqXW2SbwGTeVGSBbfV25zlZg=; b=e8cP5WMAh8sxOQsxxpIO3M1XLIEsjvKSRARX/X94dPoIm8cdRFx4M9czMwwuhS1BQPH3oj wbCX1xUz0w06XrRRiT9CnFhk5YWTHOxpvXNdnEfnEGJTYyaxklgFXzecHo1IM3MBQXo+ST Lvj1sU+tw4KDkGinFTUl6Azvgq0hT6o= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-304-vpx79HD-NRuVBolpzlM39Q-1; Fri, 22 Nov 2019 09:41:42 -0500 Received: by mail-lj1-f198.google.com with SMTP id z26so1382774ljn.5 for ; Fri, 22 Nov 2019 06:41:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=RgnI4HflXO3mCFoZIIPG2RpazzNJ3juOOlg+uXS6edE=; b=fozN/otICxkBpRnFUTj5aGmLkJ7pGMIvStnuO1IKv5rdaSZTsHWaOLsups+AxSXo1j dBzzQsP9I0Od136uzB4/T3f58pgX1vJxTOHN/5vipOAS4imoRxbw4ladR6WfDlahPi0C Q/xnFBagOCjQpHMLYUuN540vevx02vRwv1UAx2A9LFp1Fso6lcg6HApIB5YKr6aZ85Au HsVDn+FDtXlW+rjzJ3xm9bQkDf3JV+TDndhbmySFl5HHFon19mRprfGtamJrzhBzvtqy GZLPZstPHhW10p6Xv3TRouWTonTjqfY01rRHfql0CePGmH3Sy0sd73A5A0PrnnTbzcof tT6w== X-Gm-Message-State: APjAAAU+DI0TxzNLlIRZOkMyAWbtiEvJogHO09gzR4D7nuaQ4lubVGXF fzEGhFTPUIOcznarxT5vV3yDrFO/rLTkPTv9eE1hdMO4O7e+NYIGsPVw5YVTlNkywlJbl8K1w8Z CPX5V08cBNdEAUx1DXR8qmcft3dXWptAy1yQ= X-Received: by 2002:ac2:51c5:: with SMTP id u5mr12390784lfm.154.1574433700893; Fri, 22 Nov 2019 06:41:40 -0800 (PST) X-Google-Smtp-Source: APXvYqzQ5pnqBvua3JEIfWOGBY7JhXbOH3HzENeDJjuBPNzDFbI5KK+I99xCokTZBFOlPBUxPYt+Tw== X-Received: by 2002:ac2:51c5:: with SMTP id u5mr12390767lfm.154.1574433700727; Fri, 22 Nov 2019 06:41:40 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk ([2a00:7660:6da:443::2]) by smtp.gmail.com with ESMTPSA id t14sm3301298lfg.30.2019.11.22.06.41.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Nov 2019 06:41:39 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 0C4B51800B9; Fri, 22 Nov 2019 15:41:39 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Johannes Berg , Kan Yan Cc: linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net, nbd@nbd.name, yiboz@codeaurora.org, john@phrozen.org, lorenzo@kernel.org, rmanohar@codeaurora.org, kevinhayes@google.com In-Reply-To: <994e486e8e82c01e70150eacf59dedf61b80fc65.camel@sipsolutions.net> References: <20191119060610.76681-1-kyan@google.com> <20191119060610.76681-3-kyan@google.com> <3e7bea0cc643714ec90978a7999022544a39b118.camel@sipsolutions.net> <87tv6w3w92.fsf@toke.dk> <87imnc3vk9.fsf@toke.dk> <994e486e8e82c01e70150eacf59dedf61b80fc65.camel@sipsolutions.net> X-Clacks-Overhead: GNU Terry Pratchett Date: Fri, 22 Nov 2019 15:41:38 +0100 Message-ID: <874kyw3rdp.fsf@toke.dk> MIME-Version: 1.0 X-MC-Unique: vpx79HD-NRuVBolpzlM39Q-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Make-wifi-fast] [PATCH v11 2/4] mac80211: Import airtime calculation code from mt76 X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Nov 2019 14:41:46 -0000 Johannes Berg writes: > On Fri, 2019-11-22 at 14:11 +0100, Toke H=C3=B8iland-J=C3=B8rgensen wrote= : >>=20 >> as in bitrate =3D 1/airtime? Dunno, maybe? How important is precision to >> the bitrate calculations? > > Not *that* important, it's just sort of advisory for userspace. > > Though I think there's at least one place in mac80211 related to > radiotap that actually does use it for airtime calculation, which should > probably be changed to the new code now ... Yeah, I guess so. The ath9k driver is also doing software calculations for RX, so that could also be converted; and mt76 should be, of course... >> > Or maybe we should keep both and use them as a sanity check for each >> > other :P >>=20 >> Hmm, yeah, it should be possible to write a selftest to iterate through >> all rates and compare the output of each calculation, shouldn't it? >> Where would be a good place to put that? > > No idea ... make a new kselftest thing for wireless? Right; was just wondering if there was something like that already which I didn't know about :) -Toke