From: Dave Taht <dave@taht.net>
To: greearb@candelatech.com
Cc: make-wifi-fast@lists.bufferbloat.net
Subject: Re: [Make-wifi-fast] [LEDE-DEV] [PATCH] mac80211: Add patch to re-enable setting a single rate.
Date: Wed, 11 Oct 2017 15:12:14 -0700 [thread overview]
Message-ID: <874lr5z64h.fsf@nemesis.taht.net> (raw)
In-Reply-To: <1507673920-27184-1-git-send-email-greearb@candelatech.com> (greearb@candelatech.com's message of "Tue, 10 Oct 2017 15:18:40 -0700")
looks helpful on seeing if the ath10k code is still doing what we want.
greearb@candelatech.com writes:
> From: Ben Greear <greearb@candelatech.com>
>
> This lets one use 'iw' to set individual rates on ath10k again.
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
> ---
> .../111-mac80211_allow_single_tx_rate_again.patch | 33 ++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
> create mode 100644 package/kernel/mac80211/patches/111-mac80211_allow_single_tx_rate_again.patch
>
> diff --git
> a/package/kernel/mac80211/patches/111-mac80211_allow_single_tx_rate_again.patch
> b/package/kernel/mac80211/patches/111-mac80211_allow_single_tx_rate_again.patch
> new file mode 100644
> index 0000000..c88ab2b
> --- /dev/null
> +++ b/package/kernel/mac80211/patches/111-mac80211_allow_single_tx_rate_again.patch
> @@ -0,0 +1,33 @@
> +From f1f0375f67622c4f5c2faeb03c0275e4f7e8191a Mon Sep 17 00:00:00 2001
> +From: Ben Greear <greearb@candelatech.com>
> +Date: Tue, 10 Oct 2017 13:56:29 -0700
> +Subject: [PATCH] mac80211: Revert some of e8e4f5, fixes setting single rate
> + in ath10k.
> +
> +This lets us successfully set a single rate in ath10k again.
> +
> +Signed-off-by: Ben Greear <greearb@candelatech.com>
> +---
> + net/mac80211/cfg.c | 6 ++++--
> + 1 file changed, 4 insertions(+), 2 deletions(-)
> +
> +diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c
> +index d4c2511..087d33a 100644
> +--- a/net/mac80211/cfg.c
> ++++ b/net/mac80211/cfg.c
> +@@ -2756,8 +2756,10 @@ static int ieee80211_set_bitrate_mask(struct wiphy *wiphy,
> + u32 basic_rates = sdata->vif.bss_conf.basic_rates;
> + enum nl80211_band band = sdata->vif.bss_conf.chandef.chan->band;
> +
> +- if (!(mask->control[band].legacy & basic_rates))
> +- return -EINVAL;
> ++ if (!(mask->control[band].legacy & basic_rates)) {
> ++ pr_err("%s: WARNING: no legacy rates for band[%d] in set-bitrate-mask.\n",
> ++ sdata->dev->name, band);
> ++ }
> + }
> +
> + for (i = 0; i < NUM_NL80211_BANDS; i++) {
> +--
> +2.4.11
> +
parent reply other threads:[~2017-10-11 22:12 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1507673920-27184-1-git-send-email-greearb@candelatech.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/make-wifi-fast.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lr5z64h.fsf@nemesis.taht.net \
--to=dave@taht.net \
--cc=greearb@candelatech.com \
--cc=make-wifi-fast@lists.bufferbloat.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox