From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.taht.net (mail.taht.net [176.58.107.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.bufferbloat.net (Postfix) with ESMTPS id 2BC553B29E for ; Wed, 11 Oct 2017 18:12:17 -0400 (EDT) Received: from nemesis.taht.net (unknown [IPv6:2603:3024:1536:86f0:2e0:4cff:fec1:1206]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.taht.net (Postfix) with ESMTPSA id D27D421B3D; Wed, 11 Oct 2017 22:12:15 +0000 (UTC) From: Dave Taht To: greearb@candelatech.com Cc: make-wifi-fast@lists.bufferbloat.net References: <1507673920-27184-1-git-send-email-greearb@candelatech.com> Date: Wed, 11 Oct 2017 15:12:14 -0700 In-Reply-To: <1507673920-27184-1-git-send-email-greearb@candelatech.com> (greearb@candelatech.com's message of "Tue, 10 Oct 2017 15:18:40 -0700") Message-ID: <874lr5z64h.fsf@nemesis.taht.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Make-wifi-fast] [LEDE-DEV] [PATCH] mac80211: Add patch to re-enable setting a single rate. X-BeenThere: make-wifi-fast@lists.bufferbloat.net X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Oct 2017 22:12:17 -0000 looks helpful on seeing if the ath10k code is still doing what we want. greearb@candelatech.com writes: > From: Ben Greear > > This lets one use 'iw' to set individual rates on ath10k again. > > Signed-off-by: Ben Greear > --- > .../111-mac80211_allow_single_tx_rate_again.patch | 33 ++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > create mode 100644 package/kernel/mac80211/patches/111-mac80211_allow_single_tx_rate_again.patch > > diff --git > a/package/kernel/mac80211/patches/111-mac80211_allow_single_tx_rate_again.patch > b/package/kernel/mac80211/patches/111-mac80211_allow_single_tx_rate_again.patch > new file mode 100644 > index 0000000..c88ab2b > --- /dev/null > +++ b/package/kernel/mac80211/patches/111-mac80211_allow_single_tx_rate_again.patch > @@ -0,0 +1,33 @@ > +From f1f0375f67622c4f5c2faeb03c0275e4f7e8191a Mon Sep 17 00:00:00 2001 > +From: Ben Greear > +Date: Tue, 10 Oct 2017 13:56:29 -0700 > +Subject: [PATCH] mac80211: Revert some of e8e4f5, fixes setting single rate > + in ath10k. > + > +This lets us successfully set a single rate in ath10k again. > + > +Signed-off-by: Ben Greear > +--- > + net/mac80211/cfg.c | 6 ++++-- > + 1 file changed, 4 insertions(+), 2 deletions(-) > + > +diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c > +index d4c2511..087d33a 100644 > +--- a/net/mac80211/cfg.c > ++++ b/net/mac80211/cfg.c > +@@ -2756,8 +2756,10 @@ static int ieee80211_set_bitrate_mask(struct wiphy *wiphy, > + u32 basic_rates = sdata->vif.bss_conf.basic_rates; > + enum nl80211_band band = sdata->vif.bss_conf.chandef.chan->band; > + > +- if (!(mask->control[band].legacy & basic_rates)) > +- return -EINVAL; > ++ if (!(mask->control[band].legacy & basic_rates)) { > ++ pr_err("%s: WARNING: no legacy rates for band[%d] in set-bitrate-mask.\n", > ++ sdata->dev->name, band); > ++ } > + } > + > + for (i = 0; i < NUM_NL80211_BANDS; i++) { > +-- > +2.4.11 > +